Introduce streaming #107
Merged
Introduce streaming #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
force-pushed
the
introduce-streaming
branch
from
6bbd4f0
to
e833067
Compare
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 63.29% 61.97% -1.33%
==========================================
Files 11 12 +1
Lines 1049 1299 +250
==========================================
+ Hits 664 805 +141
- Misses 341 425 +84
- Partials 44 69 +25
Continue to review full report at Codecov.
|
dmcgowan
force-pushed
the
introduce-streaming
branch
12 times, most recently
from
245af9b
to
9bc00a1
Compare
|
Marking this as ready for review Benchmarking not showing a significant difference (only comparing unary requests obviously). There is one extra allocation in the new code, likely related to the new stream structure. |
mxpv
approved these changes
Mar 21, 2022
kzys
reviewed
Mar 24, 2022
Protobuild.toml
Outdated
| # enable ttrpc and disable fieldpath and grpc for the shim | ||
| prefixes = ["github.com/containerd/ttrpc/integration/streaming"] | ||
| generators = ["go", "go-ttrpc"] | ||
| plugins = ["ttrpc"] |
There was a problem hiding this comment.
You don't have to have the plugins = here.
kzys
approved these changes
Apr 7, 2022
Implementation of the 1.2 protocol with support for streaming. Provides the client and server interfaces for implementing services with streaming. Unary behavior is mostly unchanged and avoids extra stream tracking just for unary calls. Streaming calls are tracked to route data to the appropriate stream as it is received. Stricter stream ID handling, disallowing unexpected re-use of stream IDs. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Add flag to indicate that a data message used with a close flag is not sending any data. This clears up any ambiguity over whether the final data message is transmitting a zero length data message or no data at all. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
introduce-streaming
branch
from
11e50e0
to
87c043e
Compare
Closed
5 tasks
pacoxu
added a commit
to pacoxu/ttrpc
that referenced
this pull request
Jun 9, 2022
containerd#107 Signed-off-by: Paco Xu <[email protected]>
This was referenced Feb 25, 2023
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of streaming and generator for
protoc-gen-go-ttrpc. Currently no generator implementation forprotoc-gen-gogottrpc