Add support for proto3 optional #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tim-Zhang
commented
Aug 24, 2022
•
Tim-Zhang
commented
- compiler: Signal that ttrpc-compiler supports proto3 optionals
- ttrpc: bump protobuf to 2.27.1
- ttrpc-codegen: set optional as an allowd label
- example: update for optional testing
Tim-Zhang
force-pushed
the
optional-support-2.x
branch
from
f5591e2 to
c61e277
Compare
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 26.00% 26.00%
=======================================
Files 16 16
Lines 2415 2415
=======================================
Hits 628 628
Misses 1787 1787 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Got error: protoc --rust_out=. --ttrpc_out=. --plugin=protoc-gen-ttrpc=`which ttrpc_rust_plugin` test.proto test.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-ttrpc hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--ttrpc_out: According to the doc: https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md#signaling-that-your-code-generator-supports-proto3-optional Although ttrpc-compiler have already supported `proto3 optionals`, code can't be generated using `protoc` unless we signal that we support `proto3 optionals` Signed-off-by: Tim Zhang <[email protected]>
Tim-Zhang
force-pushed
the
optional-support-2.x
branch
from
c61e277 to
2a3b86c
Compare
Tim-Zhang
changed the title
|
Wait for pr stepancheg/rust-protobuf#649 |
bump protobuf to 2.27.1 Signed-off-by: Tim Zhang <[email protected]>
And bump protobuf to 2.27.1 Signed-off-by: Tim Zhang <[email protected]>
Add a optional field to health.proto. Signed-off-by: Tim Zhang <[email protected]>
Tim-Zhang
force-pushed
the
optional-support-2.x
branch
from
2a3b86c to
8ad8f2f
Compare
Tim-Zhang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.