Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-toolchain: bump rust to 1.81.0 #735

Closed
wants to merge 2 commits into from

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Nov 18, 2024

bumps rust compiler to the latest version

bumps rust compiler to the latest version

Signed-off-by: jiaxiao zhou <[email protected]>
jprendes
jprendes previously approved these changes Nov 18, 2024
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes
Copy link
Collaborator

Looks like we should be able to bump to 1.81, as that's what wasmer is using.

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
@Mossaka Mossaka changed the title rust-toolchain: bump rust to 1.82.0 rust-toolchain: bump rust to 1.81.0 Nov 18, 2024
@Mossaka Mossaka marked this pull request as ready for review November 18, 2024 17:20
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes
Copy link
Collaborator

hmm, this might be because we aren't using the latest wasmer?

@Mossaka
Copy link
Member Author

Mossaka commented Nov 18, 2024

I would love to have the Wasmer maintainers to maintain this shim. CC @dierbei

@jprendes
Copy link
Collaborator

@andreiltd has been doing some work to get the wasmer shim in shape.
He made a PR in wasmer to fix the wasmparser dependency conflict, and it got merged, but hasn't been released yet.
Maybe we can switch to a git dependency like we do in wamr?

@Mossaka
Copy link
Member Author

Mossaka commented Nov 18, 2024

Okay I will close this PR in favor of #730

@Mossaka Mossaka closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants