-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include cli implementations for adapter components #723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsturtevant !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't dug into the broken test runs, but besides that, lgtm.
Idea: We should allow users to apply environment variables or containerd configs to mutate WASI host capabilities, similar to how the Wasmtime CLI allows flags like '-Shttp' and '-Scli'. We might say, for WASI-HTTP components, the default host APIs are WASI-HTTP, no CLI, but you can configure Wasmtime shim to add CLI host APIs. Not a blocker to this PR though. |
9dfd603
to
70e92db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsturtevant !
LGTM
70e92db
to
b8ed9a1
Compare
I had to remove the changes I made to the |
I feel our makefile is overly complex. |
Doesn't actually request a change
@jsturtevant , do you want to add tests on this PR, or on a different one? |
Some languages(c# and go) always include a few imports like environment and exit. Others components that are composed with the p2 adapter will have all the imports. This makes it so those components can run by default Signed-off-by: James Sturtevant <[email protected]>
25f4fc0
to
5d8bdd0
Compare
5d8bdd0
to
320264a
Compare
Signed-off-by: James Sturtevant <[email protected]>
320264a
to
8f2d6a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Some languages (c# and go) always include a few imports like environment and exit. Others components that are composed with the p2 adapter will have all the imports. This makes it so those components can run by default.
dotnet/runtime#107405
todo: