Fix windows matching when os version is empty #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
changed the title
1 task
Member
|
I'm guessing you didn't commit the |
kiashok
reviewed
Jun 10, 2024
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
kiashok
approved these changes
Jun 10, 2024
kiashok
requested changes
Jun 10, 2024
Contributor
kiashok
left a comment
kiashok
left a comment
There was a problem hiding this comment.
Should this platforms.test file be removed?
dmcgowan
force-pushed
the
windows-compare-empty-version
branch
from
3eb8d02 to
983ba15
Compare
Member
Author
|
Removed the extra file |
kiashok
approved these changes
Jun 10, 2024
tianon
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to match a case in configuration where the target to match does not specify an os version.