adaptation: fix mount and device adjustment. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mount and device adjustment for container create request processing. Mounts in the NRI create request got incorrectly reset if a plugin ever modifed mounts. All subsequent plugins received incorrect mount data in their creation request. The same bug was present for device adjustment. Note that this had a direct effect on the NRI creation request but not the actual container itself. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/mount-and-device-adjustment
branch
from
845d510
to
43174d1
Compare
fuweid
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mount and device adjustment for container create request processing. Mounts in the NRI create request got incorrectly reset if a plugin ever modifed mounts. All subsequent plugins received incorrect mount data in their creation request. The same bug was present for device adjustment.
Note that this had a direct effect on the NRI creation request but not the actual container itself.