adaptation: fix a panic for unsolicited updates. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly set adaptation pointer during plugin creation to avoid a panic and crash for unsolicited container updates. Also make sure during initialization that we get passed a set of valid, non-nil functions pointers. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/unsolicited-update-crash
branch
from
7d0da7e
to
46304d0
Compare
fuweid
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up adaptation pointer properly during plugin creation/connection acceptance to fix a panic when a plugin sends an unsolicited container update. Also make sure that we get initialized with valid, non-nil function pointers.