refactor: extract the printing logic out of pkg for container list #2333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the issue, one of the reason of refactoring nerdctl is to make it easy for developers to import subcommand package. The current refactoring pattern of container list mixed printing logic in List() in pkg, which makes it not flexible to be imported to use. The printing logic is very specific to nerdctl cmd layer, so the idea is to moving the printing logic out of pkg, and let List() return a generic container list.
This is not the only solution to unblock the use case. The alternative is to simply make filterContainers and other functions public.