Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor run command networking options for Windows support. #1953

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Refactor run command networking options for Windows support. #1953

merged 1 commit into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. Refactor run command networking options for Windows support. 

    Refactor the loading and application of the networking-related
arguments for the `nerdctl run` command in order to enable
Windows container networking support through CNI.

To facilitate this, the following major changes were made:
    * moved all networking-related container spec definitions
      to pkg/containerutil/container_network_manager_*
    * refactored network-related argiment loading and application
      in cmd/nerdctl/container_run.go
    * enabled some of the networking-related tests on Windows

Signed-off-by: Nashwan Azhari <[email protected]>
    @aznashwan
    aznashwan committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    89a78b4 View commit details
    Browse the repository at this point in the history