Add oom-score-adj option while running #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugupt1
commented
Jul 22, 2022
| @@ -331,3 +332,14 @@ func TestRunWithFluentdLogDriverWithLogOpt(t *testing.T) { | |||
| assert.Equal(t, true, strings.Contains(logData, "test2")) | |||
| assert.Equal(t, true, strings.Contains(logData, inspectedContainer.ID)) | |||
| } | |||
|
|
|||
| func TestRunWithOOMScoreAdj(t *testing.T) { | |||
There was a problem hiding this comment.
I think it works well on docker because I have docker added in the sudo'ers group.
Code here shows rootless mode cannot be supported: https://github.com/moby/moby/blob/cf867587b9dc8edf92efd8372fcc6f86f117e386/daemon/daemon_unix.go#L1642-L1656
fuweid
approved these changes
Jul 22, 2022
fahedouch
reviewed
Jul 22, 2022
@fuweid Do you remember what is this most failed job ? |
This PR adds support for --oom-score-adj on root mode only. Signed-off-by: Manu Gupta <[email protected]>
junnplus
approved these changes
Jul 23, 2022
sorry, I should record it. Will post or file issue to track flaky cases |
fahedouch
approved these changes
Jul 23, 2022
fuweid
approved these changes
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for --oom-score-adj on
root mode only.
Testing details
Signed-off-by: Manu Gupta [email protected]