support network prune #1253
Merged
support network prune #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
junnplus
force-pushed
the
prune-network
branch
3 times, most recently
from
e411a8d to
ff4e225
Compare
manugupt1
reviewed
Jul 22, 2022
AkihiroSuda
reviewed
Jul 22, 2022
fahedouch
reviewed
Jul 22, 2022
| } | ||
| switch status.Status { | ||
| case containerd.Paused, containerd.Running: | ||
| default: |
There was a problem hiding this comment.
Why ignore containerd.Running ?
There was a problem hiding this comment.
Keep the same as docker.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
Docker doesn't clear the network in use, this is not ignored, only the network of the running/pause container will be recorded.
Signed-off-by: Ye Sijun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ye Sijun [email protected]