use free subnet to create network #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junnplus
force-pushed
the
bridge-interface
branch
11 times, most recently
from
b60900a to
5a66193
Compare
junnplus
changed the title
junnplus
force-pushed
the
bridge-interface
branch
4 times, most recently
from
3459a08 to
021eeef
Compare
manugupt1
reviewed
Jul 20, 2022
junnplus
force-pushed
the
bridge-interface
branch
2 times, most recently
from
ece73e3 to
8a898e0
Compare
fuweid
reviewed
Jul 20, 2022
| return err | ||
| } | ||
| // writeNetworkConfig writes networkConfig file to cni config path. | ||
| func (e *CNIEnv) writeNetworkConfig(net *networkConfig) error { |
There was a problem hiding this comment.
Both the Ctrl-C or No space can cancel the write and maybe there is invalid data in file. Suggest to use atomic write and make sure that content is correct.
There was a problem hiding this comment.
If needed, maybe another PR
Signed-off-by: Ye Sijun <[email protected]>
junnplus
force-pushed
the
bridge-interface
branch
from
8a898e0 to
a4b51e2
Compare
AkihiroSuda
reviewed
Jul 21, 2022
fuweid
approved these changes
Jul 21, 2022
|
Seems to have caused a regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ye Sijun [email protected]
We use increment id as the subnet part in the past, it is easy to cause subnet conflicts.
Introduce
GetFreeSubnetto find a free subnet, and check conflict when specify a subnet