Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Windows default conf paths #103

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add support for Windows default conf paths #103

merged 1 commit into from
Jul 21, 2022

Conversation

jterry75
Copy link
Contributor

@jterry75 jterry75 commented Jun 7, 2022

Signed-off-by: Justin Terry [email protected]

@jterry75 jterry75 mentioned this pull request Jun 7, 2022
Merged
@jterry75
Copy link
Contributor Author

jterry75 commented Jun 7, 2022

@vineeth-bandi

mikebrow
mikebrow approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevpar
kevpar reviewed Jun 14, 2022
View reviewed changes
types_windows.go Outdated Show resolved Hide resolved
kevpar
kevpar approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jterry75
Copy link
Contributor Author

/merge LOL

mikebrow
mikebrow approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 31de245 into containerd:main Jul 21, 2022
@jterry75
Copy link
Contributor Author

Thanks Mike!

@aznashwan aznashwan mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevpar kevpar kevpar approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jterry75 @kevpar @mikebrow