Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go vers, x/sys vendor #51

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Update Go vers, x/sys vendor #51

merged 1 commit into from
Feb 17, 2023

Conversation

estesp
Copy link
Member

@estesp estesp commented Feb 17, 2023

Update linter version and align linter settings with main containerd project.

@corhere corhere mentioned this pull request Feb 17, 2023
Closed
thaJeztah
thaJeztah approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go.mod Outdated
@@ -4,7 +4,7 @@ go 1.18

require (
github.com/stretchr/testify v1.8.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not urgent, but I saw there was a v1.8.1 as well

@thaJeztah
Copy link
Member

Ah; linter complains;

prefix=src/github.com/containerd/fifo] in [/Users/runner/work/fifo/fifo/src/github.com/containerd/fifo] ...
  Error: directive `//nolint: unconvert` is unused for linter "unconvert" (nolintlint)
  
  Error: issues found

@estesp
Update Go vers, x/sys vendor
b5d5bb2 
Update linter version and align linter settings with main containerd
project.

Signed-off-by: Phil Estes <[email protected]>
thaJeztah
thaJeztah approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

mikebrow
mikebrow approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 151b205 into containerd:main Feb 17, 2023
@estesp estesp deleted the update-xsys branch February 20, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@mikebrow mikebrow mikebrow approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estesp @thaJeztah @dmcgowan @mikebrow @austinvazquez