Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fifo_test: Add 2 tests for closing after reading #42

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

sameo
Copy link
Contributor

@sameo sameo commented Jan 26, 2022

The first test verifies that a Read() unblocks when we're closing the
reader.

The second test verifies that a Read() also unblocks when we're closing
the reader, even if a writer is pushing some bytes from the other end of
the pipe.

Signed-off-by: Samuel Ortiz [email protected]

The first test verifies that a Read() unblocks when we're closing the
reader.

The second test verifies that a Read() also unblocks when we're closing
the reader, even if a writer is pushing some bytes from the other end of
the pipe.

Signed-off-by: Samuel Ortiz <[email protected]>
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 39bc37d into containerd:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants