-
Notifications
You must be signed in to change notification settings - Fork 348
Makefile: release static binaries #415
Makefile: release static binaries #415
Conversation
@jessfraz Thanks! But I don't think other things |
It works for me like this, I know runc is and I think that is all that
matters :)
…On Tue, Nov 14, 2017 at 8:12 PM, Lantao Liu ***@***.***> wrote:
@jessfraz <https://github.com/jessfraz> Thanks!
But I don't think other things containerd, runc and cni in the tarball
are statically built. Does that matter?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#415 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYNbK4BFt9HTT06aVwBQ5wGYWu1ghBaks5s2jqbgaJpZM4QeK6_>
.
--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3
pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>
|
Signed-off-by: Jess Frazelle <[email protected]>
e49127e
to
c8584f2
Compare
@jessfraz I saw following warnings:
It seems that golang 1.9 start to report this warning. golang/go#21421 LGTM other than this. |
It's mostly just saying if you are going to dlopen something or use certain
dns features it won't work without it but dns lookups etc still should.
The binary is working for me currently.
But it's up to you all :)
…On Nov 15, 2017 21:09, "Lantao Liu" ***@***.***> wrote:
@jessfraz <https://github.com/jessfraz> I saw following warnings:
W1115 08:32:02.910] # github.com/kubernetes-incubator/cri-containerd/cmd/cri-containerd
W1115 <https://github.com/kubernetes-incubator/cri-containerd/cmd/cri-containerdW1115> 08:32:02.910] /tmp/go-link-943302640/000004.o: In function `pluginOpen':
W1115 08:32:02.911] /tmp/workdir/go/src/plugin/plugin_dlopen.go:19: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W1115 08:32:02.911] /tmp/go-link-943302640/000002.o: In function `mygetgrouplist':
W1115 08:32:02.911] /tmp/workdir/go/src/os/user/getgrouplist_unix.go:15: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W1115 08:32:02.911] /tmp/go-link-943302640/000002.o: In function `mygetgrgid_r':
W1115 08:32:02.912] /tmp/workdir/go/src/os/user/cgo_lookup_unix.go:38: warning: Using 'getgrgid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W1115 08:32:02.912] /tmp/go-link-943302640/000002.o: In function `mygetgrnam_r':
W1115 08:32:02.912] /tmp/workdir/go/src/os/user/cgo_lookup_unix.go:43: warning: Using 'getgrnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W1115 08:32:02.912] /tmp/go-link-943302640/000002.o: In function `mygetpwnam_r':
W1115 08:32:02.913] /tmp/workdir/go/src/os/user/cgo_lookup_unix.go:33: warning: Using 'getpwnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W1115 08:32:02.913] /tmp/go-link-943302640/000002.o: In function `mygetpwuid_r':
W1115 08:32:02.913] /tmp/workdir/go/src/os/user/cgo_lookup_unix.go:28: warning: Using 'getpwuid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W1115 08:32:02.913] /tmp/go-link-943302640/000000.o: In function `_cgo_b0c710f30cfd_C2func_getaddrinfo':
W1115 08:32:02.914] /tmp/go-build/net/_obj/cgo-gcc-prolog:46: warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
It seems that golang 1.9 start to report this warning. golang/go#21421
<golang/go#21421>
Will this cause any problem? It seems that cri-containerd still could not
run without glibc?
LGTM other than this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#415 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYNbNgi9pCzktLJBku5ECmv_b7_Ele1ks5s25lKgaJpZM4QeK6_>
.
|
@jessfraz OK. SGTM. I think @ijc is also using the static binary in Linuxkit now. And actually the static binary is smaller: $ # statically linked binary
$ ls -al _output/cri-containerd
-rwxrwxr-x 1 lantaol lantaol 53067112 Nov 16 01:48 _output/cri-containerd
$ # dynamically linked binary
$ ls -al /usr/local/bin/cri-containerd
-rwxr-xr-x 1 lantaol lantaol 60593328 Nov 15 02:17 /usr/local/bin/cri-containerd |
@jessfraz Thanks! |
Correct, FWIW I'm using an alpine based build env with musl which has no warnings of that sort. Not sure how (or if it is possible) to suppress that glibc warning if you know you don't care about those features, AFAIK glibc has basically decided that full static linking is not really supported... |
Was installing this on a minimal host and this would be superrrrr helpful!
Thanks!