[sandbox] refactor controller interface #7981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
force-pushed
the
sandbox-controller-interface-refactor
branch
4 times, most recently
from
b3bf31a
to
91b951d
Compare
dmcgowan
force-pushed
the
sandbox-controller-interface-refactor
branch
from
91b951d
to
65bfae2
Compare
dmcgowan
force-pushed
the
sandbox-controller-interface-refactor
branch
from
ea1ec75
to
a1dc3ff
Compare
Update the sandbox controller interface to use local types rather than using the API types. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
sandbox-controller-interface-refactor
branch
from
a1dc3ff
to
54d498e
Compare
Add options to sandbox controller interface. Update sandbox controller interface to fully utilize sandbox controller interface. Move grpc error conversion to service. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
sandbox-controller-interface-refactor
branch
from
54d498e
to
3431471
Compare
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
sandbox-controller-interface-refactor
branch
from
f3b3659
to
b0e97c0
Compare
|
Finally figured out and fixed the issue with the cleanup error. Now it uses multierror rather than checking for a non-nil empty object to signal there was an issue cleaning up. Marking as ready to review. |
|
/test pull-containerd-sandboxed-node-e2e |
1 similar comment
|
/test pull-containerd-sandboxed-node-e2e |
mxpv
approved these changes
Feb 9, 2023
cpuguy83
approved these changes
Feb 10, 2023
fuweid
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using API types in containerd interface. Move local sandbox controller plugin under the plugins package.