archive: set WithModTimeUpperBound when WithSourceDateEpoch is set #7710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
source-date-epoch-with-mod-time-upper-bound
branch
from
ee1aa87
to
9bcc745
Compare
WithModTimeUpperBound sets the upper bound value of the ModTime property of the tar entry structs. WithSourceDateEpoch now implies WithModTimeUpperBound too, in addition to WithWhiteoutTime. For moby/buildkit issue 3296 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
source-date-epoch-with-mod-time-upper-bound
branch
from
9bcc745
to
a22f0a4
Compare
This was referenced Nov 23, 2022
dmcgowan
approved these changes
Nov 29, 2022
ktock
approved these changes
Nov 30, 2022
fuweid
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithModTimeUpperBoundsets the upper bound value of theModTimeproperty of the tar entry structs.WithSourceDateEpochnow impliesWithModTimeUpperBoundtoo, in addition toWithWhiteoutTime(#7478).For
if tm > SOURCE_DATE_EPOCH { tm = SOURCE_DATE_EPOCH }for every file moby/buildkit#3296