Reverts removal of parallel run from critest #6938
Conversation
|
Hi @psschwei. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Vagrantfile
Outdated
| @@ -271,8 +271,7 @@ EOF | |||
| fi | |||
| trap cleanup EXIT | |||
| ctr version | |||
| # TODO run in parallel, see https://github.com/containerd/containerd/issues/6903 | |||
| critest --ginkgo.skip='HostIpc is true' --report-dir="${REPORT_DIR}" | |||
| critest --parallel=$(nproc) --ginkgo.skip='HostIpc is true' --report-dir="${REPORT_DIR}" | |||
There was a problem hiding this comment.
maybe nproc + some extra.. we have underutilization issues where wait loops are involved and could use some extra stress
|
/ok-to-test |
psschwei
force-pushed
the
fix-parallel
branch
2 times, most recently
from
bdc6cca
to
894d689
Compare
Signed-off-by: Paul S. Schweigert <[email protected]> As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip.
mikebrow
added
the
cherry-pick/1.6.x
mikebrow
added
cherry-picked/1.6.x
Signed-off-by: Paul S. Schweigert [email protected]
As discussed in #6903,
running ginkgo tests in parallel while trying to skip wasn't working.
However, now that
kubernetes-sigs/cri-tools#930 has fixed the
issue upstream, we can revert back to running our tests in parallel
with the skip.