cgroup2: cpu shares: follow the behavior of runc v1.3.2 #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runc v1.3.2 and crun v1.2.3 adopted the new formula for converting CPU shares to cgroup v2 weight. See opencontainers/cgroups PR 20 Signed-off-by: Akihiro Suda <[email protected]>
cpuguy83
approved these changes
Oct 27, 2025
fuweid
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runc v1.3.2 and crun v1.2.3 adopted the new formula for converting CPU shares to cgroup v2 weight.
See:
Note
The function modified in this PR does NOT appear to be actually used in containerd, as containerd utilizes runc or crun to set up the CPU weight:
https://github.com/search?q=org%3Acontainerd+ToResources&type=code
Some third-party repos seem to be using it though:
https://github.com/search?q=cgroup2.ToResources&type=code