feat(v2): Support cgroup.MoveTo in cgroupv2 manager #235
Conversation
Provides a method for the cgroup v2 manager to support moving processes to a specified cgroup. Fixes: containerd#234 Signed-off-by: yaoyinnan <[email protected]>
yaoyinnan
changed the title
|
@estesp Please help me review this PR. kata-containers/kata-containers#4397 needs this PR to be merged. Thanks. |
|
Given there is no test, how have you validated this works properly on cgroups v2? I notice that it works differently than the v1 |
|
@estesp I tested the error in the cgroupv2 environment, the error message contains "no such process", the content is as follows: This MoveTo() method exists in cgroup v1, but does not exist in cgroup v2's Manager. I need to be compatible with this method in order to make Kata compatible with cgroup v1 and cgroup v2 systems. In Kata I tested this function and it works fine. |
|
@AkihiroSuda Please help me review this PR. Thanks. |
|
@estesp Please help me contact @AkihiroSuda to help me review this PR, the kata-containers/kata-containers#4397 needs to wait for #235 to be merged. Thanks. |
|
Please consider adding a test |
Add unit test TestMoveTo() for manager.MoveTo(). Fixes: containerd#234 Signed-off-by: yaoyinnan <[email protected]>
|
@AkihiroSuda I have added the test. |
Provides a method for the cgroup v2 manager to support moving processes to a specified cgroup.
Fixes: #234
Signed-off-by: yaoyinnan [email protected]