-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add memory.min param #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergelogvinov Please add full support for this parameter including tests.
Line 179 in 4ff5113
if mem := spec.Memory; mem != nil { |
Line 452 in 2b95ef0
if len(memoryEvents) > 0 { |
Line 54 in ca6254f
func TestSystemdCgroupMemoryController(t *testing.T) { |
9b97ff7
to
b825e5f
Compare
Thank you. I've add the test. memory.events does not have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It helps to configure memory.min cgroup parameter. Signed-off-by: Serge Logvinov <[email protected]>
b825e5f
to
8276db2
Compare
Rebase and resolve conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It helps to configure memory.min cgroup param to make hard memory protection to the process group.
memory.min
exists on documentation https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html