Set the correct fsType for erofs when prefetching through the file list #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hsiangkao
suggested changes
Aug 20, 2024
When prefetching using the file list, the default fsType is ext4, even if the file system on the virtual block device is actually erofs. This sets the correct fsType based on the file system type present on the virtual block device. Signed-off-by: Hongzhen Luo <[email protected]>
salvete
changed the title
Done. Now for erofs, the fsType is determined by the superblock of the virtual block device. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When prefetching using the file list, the default fsType is ext4, even if the file system on the virtual block device is actually erofs. This sets the correct fsType based on the file system type present on the virtual block device.
The corresponding overlaybd PR:
containerd/overlaybd#344
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: