Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat.] support 'prjquota' for rootfs #286

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

BigVan
Copy link
Member

@BigVan BigVan commented May 22, 2024

users can specified rootfs usage quota through two ways:

  • 'rootfsQuota' in config.json. eg:
          { 
             ... 
            "rootfsQuota": "10g",
             ... 
         } 
  • passing the label "containerd.io/snapshot/disk_quota" when preparing container layer

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

   users can specified rootfs usage quota through two ways:
     - 'rootfsQuota' in config.json. eg:
     ```json
        {
          ...
          "rootfsQuota": "10g",
          ...
        }
     ```
     - passing the label "containerd.io/snapshot/disk_quota" when
       preparing container layer

Signed-off-by: Yifan Yuan <[email protected]>
@BigVan BigVan requested a review from liulanzheng May 22, 2024 06:39
// _, tmpinfo, _, err := storage.GetInfo(ctx, key)
id, info, _, err := storage.GetInfo(ctx, key)
if o.isPrepareRootfs(info) {
if diskQuotaSize := o.getDiskQuotaSize(&info); diskQuotaSize != "" {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit d41d4ce into containerd:main May 22, 2024
7 checks passed
WaberZhuang pushed a commit to WaberZhuang/accelerated-container-image that referenced this pull request Jun 14, 2024
[Feat.] support 'prjquota' for rootfs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants