Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Add CI for turbo and enhance other tests #260

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

WaberZhuang
Copy link
Contributor

What this PR does / why we need it:
To enhance integration testing, I did the following three things:

  • Add reproducing TurboOCI test case
  • Use a local registry within workflow containers, and the registry is configured with a self-signed certificate so we can access it via HTTPS
  • Add userspace-convertor E2E test case, it will push converted images to the local registry and run them

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@liulanzheng liulanzheng added the ok-to-test Pull request is ok to run ci test label Feb 20, 2024
Copy link
Contributor

@yuchen0cc yuchen0cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuchen0cc yuchen0cc merged commit f4c734c into containerd:main Feb 28, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Pull request is ok to run ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants