Skip to content

Commit

Permalink
Modify wording based on comments on August 3rd
Browse files Browse the repository at this point in the history
  • Loading branch information
sunnylovestiramisu committed Aug 4, 2023
1 parent 3e57adf commit c918b7f
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 18 deletions.
17 changes: 11 additions & 6 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,14 @@ message CreateVolumeRequest {
// choose where the provisioned volume is accessible from.
TopologyRequirement accessibility_requirements = 7;

// Plugin specific parameters to apply, passed in as opaque
// key-value pairs. This field is OPTIONAL. The Plugin is
// responsible for parsing and validating these parameters.
// COs will treat these as opaque. Plugins MUST treat these
// Plugin specific creation-time parameters passed in as opaque
// key-value pairs. These mutable_parameteres MAY also be
// changed during the lifetime of the volume via a subsequent
// `ControllerModifyVolume` RPC. This field is OPTIONAL.
// The Plugin is responsible for parsing and validating these
// parameters. COs will treat these as opaque.

// Plugins MUST treat these
// as if they take precedence over the parameters field.
// This field SHALL NOT be specified unless the SP has the
// MODIFY_VOLUME plugin capability.
Expand Down Expand Up @@ -1009,8 +1013,9 @@ message ControllerModifyVolumeRequest {
// section on how to use this field.
map<string, string> secrets = 2 [(csi_secret) = true];

// Plugin specific parameters to apply, passed in as opaque key-value
// pairs. This field is REQUIRED. The Plugin is responsible for
// Plugin specific volume attributes to mutate, passed in as
// opaque key-value pairs.
// This field is REQUIRED. The Plugin is responsible for
// parsing and validating these parameters. COs will treat these
// as opaque. The CO SHOULD specify the intended values of all mutable
// parameters it intends to modify. SPs MUST NOT modify volumes based
Expand Down
10 changes: 4 additions & 6 deletions lib/go/csi/csi.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 11 additions & 6 deletions spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -854,10 +854,14 @@ message CreateVolumeRequest {
// choose where the provisioned volume is accessible from.
TopologyRequirement accessibility_requirements = 7;
// Plugin specific parameters to apply, passed in as opaque
// key-value pairs. This field is OPTIONAL. The Plugin is
// responsible for parsing and validating these parameters.
// COs will treat these as opaque. Plugins MUST treat these
// Plugin specific creation-time parameters passed in as opaque
// key-value pairs. These mutable_parameteres MAY also be
// changed during the lifetime of the volume via a subsequent
// `ControllerModifyVolume` RPC. This field is OPTIONAL.
// The Plugin is responsible for parsing and validating these
// parameters. COs will treat these as opaque.
// Plugins MUST treat these
// as if they take precedence over the parameters field.
// This field SHALL NOT be specified unless the SP has the
// MODIFY_VOLUME plugin capability.
Expand Down Expand Up @@ -1667,8 +1671,9 @@ message ControllerModifyVolumeRequest {
// section on how to use this field.
map<string, string> secrets = 2 [(csi_secret) = true];
// Plugin specific parameters to apply, passed in as opaque key-value
// pairs. This field is REQUIRED. The Plugin is responsible for
// Plugin specific volume attributes to mutate, passed in as
// opaque key-value pairs.
// This field is REQUIRED. The Plugin is responsible for
// parsing and validating these parameters. COs will treat these
// as opaque. The CO SHOULD specify the intended values of all mutable
// parameters it intends to modify. SPs MUST NOT modify volumes based
Expand Down

0 comments on commit c918b7f

Please sign in to comment.