-
Notifications
You must be signed in to change notification settings - Fork 9
identity: let a roster member without a published address sign in (first-login provisioning) #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e249608
identity: mint a person for an observed roster member at login
mozhaev-dev 959c756
authenticator: provision an unknown principal at login when configured
mozhaev-dev 2ee5ec6
deploy: expose the first-login provisioning switch
mozhaev-dev 18acd52
tests: cover the login-bootstrap provisioning route on the stand
mozhaev-dev 30d559f
identity: make the login-bootstrap write refuse an already-decided ac…
mozhaev-dev 77f3e1d
deploy: refuse a provisioning switch that cannot work
mozhaev-dev 30b660b
identity: leave an account the batch can resolve to the batch
mozhaev-dev 94376a6
deploy: make the provisioning guards fire in every credential mode
mozhaev-dev cef0ffd
tests: pin the address and length refusals on the provisioning route
mozhaev-dev f39cb0d
identity: move the provisioning eligibility rules into the domain
mozhaev-dev b3fdfab
identity: apply rustfmt to the provisioning code
mozhaev-dev 35a7685
identity: defer to the other writer when the journal row is locked
mozhaev-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use the repository's required table-driven test structure. Convert the affected tests to table-driven cases with per-case assertion messages, and use the repository's
type R = Result<(), Box<dyn Error>>alias instead ofanyhow::Result<()>. This applies to the authenticator test here and the tenant-isolation cases insrc/backend/services/identity-resolution/src/api/handlers.rs; the distinct-account delimiter test already follows the intended specification style.📍 Affects 2 files
src/backend/services/authenticator/src/identity.rs#L360-L381(this comment)src/backend/services/identity-resolution/src/api/handlers.rs#L877-L948🤖 Prompt for AI Agents
Source: Coding guidelines