fix(frontend): stop rows showing through the pinned totals - #2500
Conversation
The footer default is a half-transparent tint, and the value cells in the Total row carry no background of their own, so rows travelled visibly under the totals and the two read as one smeared line. Made opaque rather than frosted. A blurred panel keeps the covered row visible by design, and what shows through is its top sliver — a data row sliced along its middle, directly under the totals. The totals need the row behind them gone, not softened. Signed-off-by: Alexey Panfilov <Alexey.Panfilov@constructor.tech>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe sticky metric timeseries totals footer now uses an opaque muted background. The presentation test verifies the ChangesMetric timeseries footer
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to The change makes pinned totals opaque so rows no longer show through beneath them, with a focused regression assertion; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Follow-up to #2465, which pinned the totals to the foot of the box. The pinning worked; the surface under it did not.
What was wrong
TableFooterdefaults to a half-transparent tint, and the value cells in the Total row carry no background of their own. Rows travelled visibly under the totals, and the two read as one smeared line.Frosted was tried first and is not what this needs
The obvious treatment is a translucent panel with a backdrop blur, and it was built that way first. Looked at side by side at the same scroll offset, it is worse:
bg-muted/85+backdrop-blur-mdbg-mutedA blurred panel keeps what is behind it visible — that is the whole idea of one — and what is behind this panel is the top sliver of a data row. The totals need the row behind them gone, not softened.
Verification
Compared in a browser at the same scroll offset on a table with real vertical overflow. The existing footer test gains an assertion that the background carries no opacity modifier, so a later "let's frost it" cannot quietly reintroduce the sliver. Unit suite green, typecheck and lint clean.
Summary by CodeRabbit