ci(e2e-stand): pass --build, the flag that replaced --build-backend - #2467
Merged
Conversation
#2455 renamed test-stand up's --build-backend to --build in dev-compose.sh but the workflow kept passing the old spelling, so both stand lanes fail at 'up' for any PR that touches src/backend/. Signed-off-by: Konstantin Tursunov <Konstantin.Tursunov@constructor.tech>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe E2E workflow now uses ChangesE2E workflow rebuild behavior
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hello1101n
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2455 replaced
test-stand up --build-backendwith--buildindev-compose.shbut left the workflow passing the old flag at both call sites, soupexits 2 (unknown test-stand up option: --build-backend) before the stand starts — both stand lanes fail for any PR whose diff touchessrc/backend/. First observed on #2463's PR run.Validation
grep -n 'build-backend' .github/workflows/e2e-stand.yml→ no remaining call sites (comments updated too)git show origin/main:dev-compose.shaccepts--buildand no longer accepts--build-backendSummary by CodeRabbit