Skip to content

ci(e2e-stand): pass --build, the flag that replaced --build-backend - #2467

Merged
ktursunov merged 1 commit into
mainfrom
ci/e2e-stand-build-flag
Aug 12, 2026
Merged

ci(e2e-stand): pass --build, the flag that replaced --build-backend#2467
ktursunov merged 1 commit into
mainfrom
ci/e2e-stand-build-flag

Conversation

@ktursunov

@ktursunov ktursunov commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

#2455 replaced test-stand up --build-backend with --build in dev-compose.sh but left the workflow passing the old flag at both call sites, so up exits 2 (unknown test-stand up option: --build-backend) before the stand starts — both stand lanes fail for any PR whose diff touches src/backend/. First observed on #2463's PR run.

Validation

  • grep -n 'build-backend' .github/workflows/e2e-stand.yml → no remaining call sites (comments updated too)
  • git show origin/main:dev-compose.sh accepts --build and no longer accepts --build-backend

Summary by CodeRabbit

  • Chores
    • Updated the end-to-end testing workflow to use the current rebuild option.
    • Revised related workflow guidance to reflect the updated process.

#2455 renamed test-stand up's --build-backend to --build in
dev-compose.sh but the workflow kept passing the old spelling, so both
stand lanes fail at 'up' for any PR that touches src/backend/.

Signed-off-by: Konstantin Tursunov <Konstantin.Tursunov@constructor.tech>
@ktursunov
ktursunov requested a review from a team as a code owner August 12, 2026 11:58
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c46f02fc-0201-4506-beeb-fffb2afe439e

📥 Commits

Reviewing files that changed from the base of the PR and between dcc02e0 and 8a3a08a.

📒 Files selected for processing (1)
  • .github/workflows/e2e-stand.yml

📝 Walkthrough

Walkthrough

The E2E workflow now uses --build instead of the removed --build-backend option for backend rebuilds. Related workflow comments were updated.

Changes

E2E workflow rebuild behavior

Layer / File(s) Summary
Replace backend rebuild commands
.github/workflows/e2e-stand.yml
The workflow comments and API smoke and UI journeys lanes now use --build when backend changes require rebuilding.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: cyberantonz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes replacing the removed --build-backend flag with --build in the e2e-stand workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/e2e-stand-build-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ktursunov
ktursunov enabled auto-merge August 12, 2026 12:08
@ktursunov
ktursunov added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit dd7b518 Aug 12, 2026
25 checks passed
@ktursunov
ktursunov deleted the ci/e2e-stand-build-flag branch August 12, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants