Skip to content

Bump the github-directory descriptor so the "None" fix can reach Airbyte #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mozhaev-dev merged 1 commit into from
Aug 11, 2026
Merged

Bump the github-directory descriptor so the "None" fix can reach Airbyte #2421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/ingestion/connectors/git/github-directory/descriptor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@

name: github-directory
# Strict semver per ADR-0015.
version: "1.0.0"
#
# 1.0.1 — the manifest stopped storing absent profile fields as the text
# "None" (#2393). The bump is what makes that reach Airbyte at all: reconcile
# republishes a nocode manifest only on descriptor-version drift, so the
# previous manifest-only change was live in the repo and inert on every
Comment on lines +15 to +18

@coderabbitai coderabbitai Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

rg -n -C 4 '`#2393`|`#2415`|descriptor-version|reconcile' src/ingestion/connectors/git/github-directory/descriptor.yaml src/ingestion 2>/dev/null | head -200
printf '\nRemotes:\n'
git remote -v

Repository: constructorfabric/insight

Length of output: 19813

🌐 Web query:

site:github.com/constructorfabric/insight/issues/2393 OR site:github.com/constructorfabric/insight/issues/2415

💡 Result:

  • Issue #2393: After sign-in, the portal can show another employee’s profile/data because identity resolution maps missing GitHub emails to the literal "None", grouping users incorrectly. It was opened August 10, 2026 and remains open. [1]
  • PR #2415: Fixes this by converting missing GitHub profile fields (email, name, company, role) to empty strings instead of "None". It was merged into main on August 11, 2026, but existing incorrect identity records require separate data repair. [2]

Update the descriptor comment to reference #2415 as the fix.

#2393 is the original bug report. Keep it only as a secondary reference.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/ingestion/connectors/git/github-directory/descriptor.yaml` around lines
15 - 18, Update the version comment in the descriptor manifest to identify `#2415`
as the primary fix reference, while retaining `#2393` only as a secondary
reference to the original bug report.

# cluster.
version: "1.0.1"
# `nocode` = declarative-manifest connector (connector.yaml published to the
# Airbyte builder), as opposed to `cdk`. MUST be `nocode`/absent for
# declarative connectors: reconcile only branches on `nocode` vs `cdk` — any
Expand Down
Loading