-
Notifications
You must be signed in to change notification settings - Fork 9
feat(analytics): group metric definitions by subject, add tags #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cyberantonz
merged 2 commits into
constructorfabric:main
from
cyberantonz:fix/2344-metric-subject-tags
Aug 11, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Parse bounded metadata slugs at the registry boundary.
subjectandtagsremain raw strings. The current tests accept values longer than theVARCHAR(64)columns. A future registry entry can passcargo testand then fail or truncate during reconciliation.src/backend/services/analytics/src/domain/metric_definitions/builtin.rs#L102-L109: Replace raw metadata strings with parsedMetricSubjectandMetricTagboundary types that enforce lowercase snake case and a 64-character maximum.src/backend/services/analytics/src/domain/metric_definitions/builtin.rs#L325-L354: Test the maximum length and retain per-metric tag uniqueness validation.docs/domain/metrics/specs/DESIGN.md#L663-L669: State the 64-character maximum in the metric-authoring instructions.As per coding guidelines, “Parse, don't validate: introduce boundary newtypes … and do not carry raw
Stringvalues through layers.”📍 Affects 2 files
src/backend/services/analytics/src/domain/metric_definitions/builtin.rs#L102-L109(this comment)src/backend/services/analytics/src/domain/metric_definitions/builtin.rs#L325-L354docs/domain/metrics/specs/DESIGN.md#L663-L669🤖 Prompt for AI Agents
Source: Coding guidelines