fix(stand): pin the UI journeys to the legacy shell - #2386
Merged
Conversation
The portal became opt-out: an absent `insight.portal` key now renders the portal, so a fresh browser context stopped meaning "the dashboard shell these journeys were written against" and 12 of 17 journeys timed out inside the portal UI. The context fixture now seeds `insight.portal = "false"` via an init script, which runs before any app code on every page — the one moment the flag is guaranteed to precede the first read. The suite's tested surface stays the legacy shell, stated explicitly, until portal journeys exist. Verified against a stand on the portal-default-on frontend: without the flag a previously green journey fails; with it the UI suite passes 17 of 17. Signed-off-by: Konstantin Tursunov <Konstantin.Tursunov@constructor.tech>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe UI test setup adds a browser context fixture that sets ChangesUI test setup
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ktursunov
enabled auto-merge
August 10, 2026 09:51
hello1101n
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#2358 made the portal opt-out: an absent
insight.portalkey now renders the portal, and only an explicit"false"returns the legacy dashboard shell. The stand UI journeys drive the legacy shell in fresh browser contexts — no localStorage key — so on any stand running the current frontend they land in the portal and time out on legacy selectors: 12 of 17 journeys failed (5.5-minute run, all timeout-shaped) in the first stand run after the frontend pin picked up the change.api-smokestayed green throughout — the stand and data pipeline are fine; only the UI surface moved under the UI tests.What changed
One
contextfixture override intests/stand/ui/conftest.py: every journey context seedsinsight.portal = "false"viaadd_init_script, which runs before any app code on every page — the one moment guaranteed to precede the flag's first read. The suite's tested surface stays the legacy shell, stated explicitly, until portal journeys exist (that coverage is its own scoping decision, not this fix).Verification (live compose stand, frontend
2026.08.10.06.40)test_single_metric_block_opens_that_metrics_dialog) fails on this frontend — the breakage reproduces locally.Notes
Follow-up to #2336, which fixed the stand's seed/identity pipeline — this restores the UI lane on top of it.
Summary by CodeRabbit