fix(github-directory): tag dbt models with the connector slug - #2364
Merged
Conversation
The sync pipeline does not use descriptor.dbt_select for non-jira connectors: ingestion-pipeline derives the selector from the connector slug as `tag:<data_source>+` and ignores the parameter it is passed. The models were tagged `github_directory` while the slug is `github-directory`, so the transform step selected nothing. dbt exits 0 when a selector matches no nodes, so the step reported success and the rows stopped at bronze. Retags the four models and aligns descriptor.dbt_select with the selector actually used. Refs #2362 Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe changes rename the GitHub Directory dbt tag from ChangesGitHub Directory tag alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aleksdotbar
enabled auto-merge
August 10, 2026 05:24
ktursunov
approved these changes
Aug 10, 2026
cyberantonz
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ingestion-pipelinederives the dbt selector from the connector slug astag:<data_source>+and ignores thedbt_selectit is passed (non-jira path). Models were taggedgithub_directory, slug isgithub-directory— selector matched nothing, rows stopped at bronze.dbt exits 0 on an empty selection, so the step reported success.
Fix
Retag the 4 models to
github-directory. Aligndescriptor.dbt_selectwith the selector actually used.Scope
Fixes the
github-directoryhalf of #2362. dbt exiting 0 on an empty selection is untouched — until that fails loudly, the next mismatch is equally invisible.Verification
connector_wiring.pygreen,validate-strictpasses, 8 mock tests pass.Summary by CodeRabbit
github_directorytogithub-directory.