Skip to content

fix(github-directory): tag dbt models with the connector slug - #2364

Merged
aleksdotbar merged 1 commit into
mainfrom
claude/github-directory-dbt-tag
Aug 10, 2026
Merged

fix(github-directory): tag dbt models with the connector slug#2364
aleksdotbar merged 1 commit into
mainfrom
claude/github-directory-dbt-tag

Conversation

@aleksdotbar

@aleksdotbar aleksdotbar commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Problem

ingestion-pipeline derives the dbt selector from the connector slug as tag:<data_source>+ and ignores the dbt_select it is passed (non-jira path). Models were tagged github_directory, slug is github-directory — selector matched nothing, rows stopped at bronze.

dbt exits 0 on an empty selection, so the step reported success.

Fix

Retag the 4 models to github-directory. Align descriptor.dbt_select with the selector actually used.

Scope

Fixes the github-directory half of #2362. dbt exiting 0 on an empty selection is untouched — until that fails loudly, the next mismatch is equally invisible.

Verification

connector_wiring.py green, validate-strict passes, 8 mock tests pass.

Summary by CodeRabbit

  • Chores
    • Standardized the GitHub Directory data pipeline tag format from github_directory to github-directory.
    • Applied the updated tag consistently across related models, snapshots, and selection configuration.

The sync pipeline does not use descriptor.dbt_select for non-jira
connectors: ingestion-pipeline derives the selector from the connector
slug as `tag:<data_source>+` and ignores the parameter it is passed. The
models were tagged `github_directory` while the slug is
`github-directory`, so the transform step selected nothing.

dbt exits 0 when a selector matches no nodes, so the step reported
success and the rows stopped at bronze.

Retags the four models and aligns descriptor.dbt_select with the
selector actually used.

Refs #2362

Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar>
@aleksdotbar
aleksdotbar requested a review from a team as a code owner August 10, 2026 05:22
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c00e5a6b-504c-43b6-b135-6ea9832aaa90

📥 Commits

Reviewing files that changed from the base of the PR and between 4208286 and 33bba6d.

📒 Files selected for processing (5)
  • src/ingestion/connectors/git/github-directory/dbt/github_directory__bronze_promoted.sql
  • src/ingestion/connectors/git/github-directory/dbt/github_directory__identity_inputs.sql
  • src/ingestion/connectors/git/github-directory/dbt/github_directory__org_members_fields_history.sql
  • src/ingestion/connectors/git/github-directory/dbt/github_directory__org_members_snapshot.sql
  • src/ingestion/connectors/git/github-directory/descriptor.yaml

📝 Walkthrough

Walkthrough

The changes rename the GitHub Directory dbt tag from github_directory to github-directory across four dbt models or snapshots and update the descriptor selector to match.

Changes

GitHub Directory tag alignment

Layer / File(s) Summary
Align dbt tags and selector
src/ingestion/connectors/git/github-directory/dbt/*, src/ingestion/connectors/git/github-directory/descriptor.yaml
Four dbt configurations and the descriptor dbt_select value now use github-directory.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • constructorfabric/insight issue 2362 — It identifies the selector mismatch addressed by these tag changes.

Possibly related PRs

Suggested reviewers: cyberantonz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the fix: aligning GitHub Directory dbt model tags with the connector slug.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/github-directory-dbt-tag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aleksdotbar
aleksdotbar enabled auto-merge August 10, 2026 05:24
@aleksdotbar
aleksdotbar added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 0fd8048 Aug 10, 2026
66 of 68 checks passed
@aleksdotbar
aleksdotbar deleted the claude/github-directory-dbt-tag branch August 10, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connector transforms are skipped silently when the dbt selector matches no models

3 participants