Skip to content

chore: remove leftover .NET traces from CI and docker context - #2327

Merged
cyberantonz merged 1 commit into
constructorfabric:mainfrom
cyberantonz:chore/remove-dotnet-traces
Aug 7, 2026
Merged

chore: remove leftover .NET traces from CI and docker context#2327
cyberantonz merged 1 commit into
constructorfabric:mainfrom
cyberantonz:chore/remove-dotnet-traces

Conversation

@cyberantonz

Copy link
Copy Markdown
Contributor

The .NET identity service is fully decommissioned and no C# code remains in the repository, but two pieces of tooling still assumed it existed:

  • semgrep workflow: drop the p/csharp ruleset from both scan passes (nothing left for it to match) and update the comment/summary text accordingly.
  • src/backend/.dockerignore: remove the .NET bin/obj block, Visual Studio state (.vs, *.user, *.suo), and TestResults, and fix the stale header that still described the build context as serving the retired api-gateway/analytics/identity trio.

Deliberately not touched (load-bearing history/parity documentation): the identity-resolution migration parity comments and frozen sql/001–013 scripts, the e2e capability shims in tests/e2e/lib/identity.py, and historical mentions in specs/ADRs.

Known remaining .NET residue, out of scope here: the committed identity OpenAPI contract is still the .NET document (blocked on identity-resolution growing an openapi subcommand, as authenticator did in #2000), and migration/mod.rs still states the additive-only-until-decommission rollback policy.

🤖 Generated with Claude Code

The .NET identity service is fully decommissioned; no C# code remains
in the repository.

- semgrep: drop the p/csharp ruleset from both scan passes (nothing
  left for it to match) and update the comment/summary text.
- src/backend/.dockerignore: remove the .NET bin/obj block, Visual
  Studio state, and TestResults, and fix the stale header that still
  described the retired api-gateway/analytics/identity trio.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Anton Zelenov <antonz@constructor.tech>
@cyberantonz
cyberantonz requested a review from a team as a code owner August 7, 2026 08:31
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cyberantonz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bb1e8ff0-fbf7-4420-87c6-483047f5db4a

📥 Commits

Reviewing files that changed from the base of the PR and between 27eac0e and 4e69d92.

📒 Files selected for processing (2)
  • .github/workflows/semgrep.yml
  • src/backend/.dockerignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cyberantonz
cyberantonz enabled auto-merge August 7, 2026 08:31
@cyberantonz
cyberantonz added this pull request to the merge queue Aug 7, 2026
Merged via the queue into constructorfabric:main with commit ff373ca Aug 7, 2026
51 checks passed
@cyberantonz
cyberantonz deleted the chore/remove-dotnet-traces branch August 7, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants