docs(authenticator): record the broker-era reuse map (EPIC #2193 Phase 5) - #2319
Merged
cyberantonz merged 1 commit intoAug 7, 2026
Merged
Conversation
…rfabric#2193 Phase 5) The reuse-map bullet now states what the broker adoption actually reused: Keycloak subchart + keycloak-config-cli as adopted externals, the seed package's insight-seed-realm generator shared by compose/local/CI/e2e (the single token contract that allowed deleting fakeidp), and the host-keyed issuer map as the only authenticator code the broker required. The ADR-0003 half of Phase 5 landed earlier (constructorfabric#2203 Confirmation section + status-history amendments). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Anton Zelenov <antonz@constructor.tech>
cyberantonz
enabled auto-merge
August 7, 2026 06:00
📝 WalkthroughWalkthroughThe authenticator design document now records Keycloak broker adoption, shared realm configuration, fakeidp removal, and host-based issuer selection. ChangesAuthenticator broker documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/components/backend/authenticator/DESIGN.md`:
- Line 969: The reuse-map description uses the ambiguous “roster realm” label;
update the related references around the seed package and realm configuration to
use one canonical Keycloak realm/artifact name consistent with the seeded
output, compose issuer, and gitops artifact. Ensure readers can directly map the
seed output to the deployable realm without guessing, while preserving the
existing reuse and configuration details.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 375d1f15-e33d-460c-9413-0ef21046fc85
📒 Files selected for processing (1)
docs/components/backend/authenticator/DESIGN.md
cyberantonz
disabled auto-merge
August 7, 2026 06:38
cyberantonz
enabled auto-merge
August 7, 2026 06:38
ktursunov
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the EPIC #2193 Phase 5 task ("Amend ADR-0003 with PoC findings; update the DESIGN reuse map").
oidc-provider back-channel gap), and the status history carries the subsequent amendments (in-stack subchart, per-registration tenant pin, fakeidp retirement).insight-seed-realmgenerator shared unchanged by compose/local/CI/e2e (the single token contract that made deleting fakeidp possible, feat(auth): retire fakeidp — Keycloak is the IdP everywhere #2315), and the host-keyed issuer map (issuers.rs) as the only authenticator code the broker required.cfs validate / toc / check-language: clean.
🤖 Generated with Claude Code
Summary by CodeRabbit