-
Notifications
You must be signed in to change notification settings - Fork 9
feat(seed): run the demo seeder on Kubernetes stands #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
960ef7d
feat(seed): run the demo seeder on Kubernetes stands
03f50ca
refactor(seed): install the seeder as a package instead of running it…
5a895d9
ci(e2e-stand): install uv in the ui-journeys job
d15a30f
fix(seed): address the review findings
0a6ecc1
chore: keep the Studio tooling files out of this branch
b85cd34
fix(seed): close the gaps a second review pass found
b911316
build(seed): publish the seeder as its own image
75a9f07
fix(authenticator): point the e2e rig at the relocated realm generator
e1a8204
fix(seed): register the task issue-type relation in the reset surface
eb6f054
ci(seed): match the action pins the actions bump landed on main
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Add the image CVE gate before the seed manifest is tagged.
merge-toolboxruns./.github/actions/image-cve-gatebeforedocker buildx imagetools create(lines 1083-1088), so no tag points at an image with a fixable critical.merge-seedomits both the checkout and that gate. The publishedinsight-seedtags therefore bypass the scan that every other merged image passes.🛡️ Proposed fix
- uses: docker/metadata-action@c299e40c65443455700f0fdfc63efafe5b349051 # v5 id: meta with: images: ${{ env.IMAGE_PREFIX }}/insight-seed tags: | type=raw,value=${{ needs.changes.outputs.build_tag }} type=raw,value=latest,enable=${{ github.ref == 'refs/heads/main' }} + - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 + with: + persist-credentials: false + - name: Fail on a fixable critical before any tag points here + uses: ./.github/actions/image-cve-gate + with: + image: ${{ env.IMAGE_PREFIX }}/insight-seed + registry-username: ${{ github.actor }} + registry-password: ${{ secrets.GITHUB_TOKEN }} - name: Create multi-arch manifest and push📝 Committable suggestion
🤖 Prompt for AI Agents