docs(person-attributes): design attribute cohorting architecture (#2028)

[aleksdotbar]

Summary

• define the GRAPH 7: [EPIC] Cohorting is a GROUP BY over identity attributes #2028 person-attribute and cohorting architecture
• record data-ownership and identity/temporal decisions
• register the artifacts with Constructor Studio

Validation

• cfs toc
• cfs validate-toc
• cfs validate --artifact
• cfs list-ids
• git diff --check

Tests were not run because this change is documentation-only.

Summary by CodeRabbit

• New Features

  • Added support for a Person Attributes and Cohorting system within InsightSpec.
  • Documented connector-discovered attributes, cohorting, identity resolution, temporal behavior, security, privacy, and operational workflows.
  • Defined policies for attribute ownership, immutable revisions, analytical querying, and named-group membership.

• Documentation

  • Added a technical design and two architecture decision records covering data ownership, identity, and time semantics.

[coderabbitai]

Warning

Review limit reached

@aleksdotbar, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 04b89037-4e28-4855-baa2-e9e46f25f929

📥 Commits

Reviewing files that changed from the base of the PR and between 178b6de and 72528a9.

📒 Files selected for processing (4)

• .cf-studio/config/artifacts.toml
• docs/domain/person-attributes/specs/ADR/0001-attribute-data-ownership-v1.md
• docs/domain/person-attributes/specs/ADR/0002-identity-and-time-semantics-v1.md
• docs/domain/person-attributes/specs/DESIGN.md

📝 Walkthrough

Walkthrough

The PR registers the Person Attributes and Cohorting system under InsightSpec. It adds a technical design and two ADRs covering architecture, data ownership, identity resolution, temporal semantics, storage, APIs, and cohort queries.

Changes

Person Attributes and Cohorting

Layer / File(s)	Summary
System and artifact registration .cf-studio/config/artifacts.toml	Registers person-attributes as an InsightSpec child and adds the system with its design and ADR artifacts.
Technical design docs/domain/person-attributes/specs/DESIGN.md	Defines the architecture, domain entities, APIs, storage schemas, query flows, identity integration, and operational requirements.
Attribute data ownership docs/domain/person-attributes/specs/ADR/0001-attribute-data-ownership-v1.md	Documents split ownership between ClickHouse and Identity MariaDB, with immutable policy publication to ClickHouse.
Identity and time semantics docs/domain/person-attributes/specs/ADR/0002-identity-and-time-semantics-v1.md	Documents source-account identity, corrective assignments, effective dating, metric compatibility, temporal comparisons, and named-group membership.
Estimated code review effort: 3 (Moderate)	~20 minutes

Possibly related PRs

• constructorfabric/insight#1790: Covers related identity-resolution and account-to-person semantics.

Suggested reviewers: cyberantonz

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: documenting the person-attributes and cohorting architecture.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

⚔️ Resolve merge conflicts 💡

• Resolve merge conflict in branch docs/person-attributes-cohorting-design

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch docs/person-attributes-cohorting-design

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}