fix(seed): add login identity for other-tenant persona

[aleksdotbar]

What

Seed the Keycloak login identity for the cross-tenant test persona under its own tenant.

The persona existed in the generated realm and identity roster, but lacked the value_type=id observation required by login bootstrap. Its callback was therefore rejected as an unknown person, failing the stand API suite.

Test

• python3 -m unittest deploy/seed/test_identity.py -v
• ruff check deploy/seed/identity.py

Summary by CodeRabbit

• Bug Fixes
  • Improved seeded identity data by including login-ID records for secondary tenant scenarios.
• Tests
  • Updated identity operation coverage to reflect the removal of an obsolete email-based lookup path.
  • Adjusted operation catalogs and validation expectations accordingly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1bec77c9-cf99-46a0-bf2f-70fcaa31560f

📥 Commits

Reviewing files that changed from the base of the PR and between 25ca9bd and 3732446.

📒 Files selected for processing (2)

• deploy/seed/identity.py
• tests/stand/api/operations.py

---

📝 Walkthrough

Walkthrough

The secondary-tenant seed flow now inserts login-ID observations. The identity operation catalog removes the email-based operation and its stand-in parameter, reducing the catalog count from 18 to 17.

Changes

Identity updates

Layer / File(s)	Summary
Secondary-tenant login-ID seeding deploy/seed/identity.py	The secondary-tenant seed flow calls seed_login_ids and adds its inserted-row count to n_login_id.
Identity operation catalog cleanup tests/stand/api/operations.py	The email stand-in, {email} mapping, and GET /internal/persons/by-email/{email} operation are removed. The catalog count changes to 17.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• constructorfabric/insight#1897: Modifies identity E2E operation coverage for the email-based identity operation.
• constructorfabric/insight#1989: Adds login-ID seeding and removes the deprecated email identity operation.
• constructorfabric/insight#2046: Adds secondary-tenant login-ID seeding and changes related identity operations.

Suggested reviewers: cyberantonz, ktursunov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: adding a login identity for the other-tenant persona.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/test-stand-other-tenant-login

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}