fix(backend): revert reqwest to 0.12 — authenticator OIDC stack pins its client impls to it - #2181
Conversation
… client impls to it Dependabot constructorfabric#2160 bumped the workspace reqwest to 0.13.4, but openidconnect 4 / oauth2 5 (the authenticator's OIDC stack) implement AsyncHttpClient only for reqwest 0.12, and no released version supports 0.13 yet. The bump made the authenticator fail to compile, unnoticed because the authenticator workflow's path filter does not cover workspace manifests. - Pin workspace reqwest back to 0.12 (the gears oidc-authn-plugin keeps its private 0.13 copy, as before the bump). - Dependabot: ignore reqwest >=0.13 until a released openidconnect supports it. - Authenticator workflow: also trigger on src/backend/Cargo.toml and Cargo.lock so a workspace dependency bump exercises the authenticator build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Anton Zelenov <antonz@constructor.tech>
|
Warning Review limit reached
Next review available in: 36 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What / why
Dependabot #2160 bumped the workspace
reqwest0.12.28 → 0.13.4.openidconnect4 /oauth25 — the authenticator's OIDC client stack — implementAsyncHttpClientonly for reqwest 0.12, and no released version supports 0.13 yet (checked crates.io: openidconnect 4.0.1 and oauth2 5.0.0 are the latest). Result: the authenticator does not compile on main (9 × E0277, "multiple different versions of cratereqwest"), first surfaced by the drift gate on the unrelated docs PR #2170.It slipped through because the authenticator workflow's path filter covers only authenticator sources — not the workspace
Cargo.toml/Cargo.lockthe bump touched.Changes
reqwestback to0.12(lock re-resolved; the gearsoidc-authn-pluginkeeps its private 0.13 copy exactly as before the bump).dependabot.yml: ignorereqwest >= 0.13until a released openidconnect supports it (rule carries the lift condition as a comment).authenticator.ymlworkflow: also trigger onsrc/backend/Cargo.toml+Cargo.lockso workspace dependency bumps exercise the authenticator build.Verification
cargo check -p authenticatorandcargo check --workspace: clean.cargo test -p authenticator: 57 passed, 0 failed.🤖 Generated with Claude Code