Skip to content

fix(backend): revert reqwest to 0.12 — authenticator OIDC stack pins its client impls to it - #2181

Merged
lobster40 merged 1 commit into
constructorfabric:mainfrom
cyberantonz:fix/authenticator-reqwest-dup
Aug 4, 2026
Merged

fix(backend): revert reqwest to 0.12 — authenticator OIDC stack pins its client impls to it#2181
lobster40 merged 1 commit into
constructorfabric:mainfrom
cyberantonz:fix/authenticator-reqwest-dup

Conversation

@cyberantonz

Copy link
Copy Markdown
Contributor

What / why

Dependabot #2160 bumped the workspace reqwest 0.12.28 → 0.13.4. openidconnect 4 / oauth2 5 — the authenticator's OIDC client stack — implement AsyncHttpClient only for reqwest 0.12, and no released version supports 0.13 yet (checked crates.io: openidconnect 4.0.1 and oauth2 5.0.0 are the latest). Result: the authenticator does not compile on main (9 × E0277, "multiple different versions of crate reqwest"), first surfaced by the drift gate on the unrelated docs PR #2170.

It slipped through because the authenticator workflow's path filter covers only authenticator sources — not the workspace Cargo.toml/Cargo.lock the bump touched.

Changes

  • Pin workspace reqwest back to 0.12 (lock re-resolved; the gears oidc-authn-plugin keeps its private 0.13 copy exactly as before the bump).
  • dependabot.yml: ignore reqwest >= 0.13 until a released openidconnect supports it (rule carries the lift condition as a comment).
  • authenticator.yml workflow: also trigger on src/backend/Cargo.toml + Cargo.lock so workspace dependency bumps exercise the authenticator build.

Verification

  • cargo check -p authenticator and cargo check --workspace: clean.
  • cargo test -p authenticator: 57 passed, 0 failed.
  • pre-commit (incl. clippy, yamlfmt): passed.

🤖 Generated with Claude Code

… client impls to it

Dependabot constructorfabric#2160 bumped the workspace reqwest to 0.13.4, but openidconnect 4
/ oauth2 5 (the authenticator's OIDC stack) implement AsyncHttpClient only
for reqwest 0.12, and no released version supports 0.13 yet. The bump made
the authenticator fail to compile, unnoticed because the authenticator
workflow's path filter does not cover workspace manifests.

- Pin workspace reqwest back to 0.12 (the gears oidc-authn-plugin keeps its
  private 0.13 copy, as before the bump).
- Dependabot: ignore reqwest >=0.13 until a released openidconnect supports
  it.
- Authenticator workflow: also trigger on src/backend/Cargo.toml and
  Cargo.lock so a workspace dependency bump exercises the authenticator
  build.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Anton Zelenov <antonz@constructor.tech>
@cyberantonz
cyberantonz requested a review from a team as a code owner August 4, 2026 09:51
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cyberantonz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5d6b121e-7f83-49e9-abde-4e78f0027112

📥 Commits

Reviewing files that changed from the base of the PR and between 59f0634 and 1638648.

⛔ Files ignored due to path filters (1)
  • src/backend/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .github/dependabot.yml
  • .github/workflows/authenticator.yml
  • src/backend/Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cyberantonz
cyberantonz enabled auto-merge August 4, 2026 09:56
@cyberantonz
cyberantonz added this pull request to the merge queue Aug 4, 2026
@lobster40
lobster40 removed this pull request from the merge queue due to a manual request Aug 4, 2026
@lobster40
lobster40 added this pull request to the merge queue Aug 4, 2026
@cyberantonz
cyberantonz removed this pull request from the merge queue due to a manual request Aug 4, 2026
@lobster40
lobster40 merged commit 6493f56 into constructorfabric:main Aug 4, 2026
54 of 57 checks passed
@cyberantonz
cyberantonz deleted the fix/authenticator-reqwest-dup branch August 5, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants