security: merge the hardening branch into main (2/2 — after insight-front#258) - #2143
Check failed
There is one commit incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | f0e1755 | fix(helm): read-only root filesystem for the remai... | Valid sign-off found |
| 🟢 | 32b829a | fix(ingestion): resolve nltk and langchain-core to... | Valid sign-off found |
| 🟢 | 1f11a51 | fix(ingestion): hold uv back from just-published r... | Valid sign-off found |
| 🟢 | 39341c5 | fix(helm): declare securityContext for fakeidp and... | Valid sign-off found |
| 🟢 | 79842fa | fix(images): run the tooling images as a non-root ... | Valid sign-off found |
| 🟢 | 635784d | fix(images): add --no-install-recommends to the to... | Valid sign-off found |
| 🟢 | 678c095 | chore(security): waive DS-0002 for the e2e runner ... | Valid sign-off found |
| 🟢 | cbb5c1a | chore(security): pass the scoped waiver file to Tr... | Valid sign-off found |
| 🟢 | e47fc8a | fix(images): create the cargo cache dirs before ch... | Valid sign-off found |
| 🟢 | 57fc697 | ci(security): pin third-party actions to digests i... | Valid sign-off found |
| 🟢 | 738302e | fix(helm): run the frontend as a non-root user on ... | Valid sign-off found |
| 🟢 | d0d389a | Merge pull request #2085 from constructorfabric/fi... | Skipped: sign-off not required in merge commit |
| 🟢 | d3b29d5 | Merge pull request #2089 from constructorfabric/fi... | Skipped: sign-off not required in merge commit |
| 🟢 | 9c2199f | Merge pull request #2094 from constructorfabric/ci... | Skipped: sign-off not required in merge commit |
| 🟢 | cf34085 | Merge pull request #2095 from constructorfabric/fi... | Skipped: sign-off not required in merge commit |
| 🟢 | 2d0d4ff | fix(ingestion): override cryptography in the conne... | Valid sign-off found |
| 🔴 | 68b8dfe | ci(security): pin third-party actions to digests, ... | No sign-off matches the author or committer |
| 🟢 | a88f326 | Merge pull request #2119 from constructorfabric/fi... | Skipped: sign-off not required in merge commit |
| 🟢 | c1bddaf | Merge pull request #2083 from constructorfabric/fi... | Skipped: sign-off not required in merge commit |
| 🟢 | 48f4d64 | fix(seed): raise mypy past the pathspec split so d... | Valid sign-off found |
| 🟢 | 6db8c52 | Merge pull request #2121 from constructorfabric/fi... | Skipped: sign-off not required in merge commit |
| 🟢 | 9fe9802 | fix(ci): pass --ignorefile to trivy instead of to ... | Valid sign-off found |
| 🟢 | ffd71f6 | Merge branch 'main' into security-hardening | Skipped: sign-off not required in merge commit |
Errors details
No sign-off matches the author or committer
A valid sign-off was found in the commit message, but it doesn't match neither the author nor the committer. Make sure that both the name and email in the sign-off line match the author or committer of the commit.
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~23 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin security-hardening