Skip to content

chore(bootstrap-db): address #1940 review — exact venv pins, consistent docs - #1954

Merged
cyberantonz merged 2 commits into
constructorfabric:mainfrom
cyberantonz:chore/bootstrap-db-review-fixes
Jul 28, 2026
Merged

chore(bootstrap-db): address #1940 review — exact venv pins, consistent docs#1954
cyberantonz merged 2 commits into
constructorfabric:mainfrom
cyberantonz:chore/bootstrap-db-review-fixes

Conversation

@cyberantonz

Copy link
Copy Markdown
Contributor

Follow-up to #1940 (merged before the CodeRabbit findings were addressed):

  • run-dbt.sh: exact-equality version check on both dbt-core and dbt-clickhouse (the substring match accepted e.g. 1.9.6.post1, and a DBT_CORE_VERSION-only bump in pins.env silently reused a stale venv). Verified against a real venv: correct pins accepted, wrong pin and missing package rejected.
  • README: the local-ClickHouse example now uses the LAN IP, matching the prerequisites (host.docker.internal doesn't resolve on the macOS host); snapshot fallback paths made relative to bootstrap-db/.
  • connectors-ddl-reminder workflow: same fallback-path fix in the generated comment.

🤖 Generated with Claude Code

- run-dbt.sh: exact-equality version check on both dbt-core and
  dbt-clickhouse (substring match accepted e.g. 1.9.6.post1; a
  DBT_CORE_VERSION-only bump reused a stale venv).
- README: local ClickHouse example now uses the LAN IP like the
  prerequisites; snapshot fallback paths relative to bootstrap-db/.
- Reminder workflow: same path fix.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Anton Zelenov <antonz@constructor.tech>
@cyberantonz
cyberantonz requested a review from a team as a code owner July 27, 2026 16:18
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cyberantonz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fae1cbd5-4e02-4735-b5d5-0211c89aab4a

📥 Commits

Reviewing files that changed from the base of the PR and between 1ec2596 and 413e32d.

📒 Files selected for processing (3)
  • .github/workflows/connectors-ddl-reminder.yml
  • src/ingestion/scripts/bootstrap-db/README.md
  • src/ingestion/scripts/bootstrap-db/run-dbt.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Regenerate the connectors-ddl snapshot

This PR changes src/ingestion/**. If your change affects any
bronze / silver / gold schema, regenerate the committed DDL snapshot
and include it in this PR.

Prerequisites (details: src/ingestion/scripts/bootstrap-db/README.md):

  • docker + a fresh throwaway ClickHouse 25.7.5 (README "Local ClickHouse for testing")
  • .env from .env.bootstrap.example pointing at it; use the host LAN IP,
    reachable from both the host and connector containers
    (host.docker.internal does not resolve on the macOS host itself)
  • python3.12 or python3.11 on PATH (pinned dbt venv)
  • HubSpot + Salesforce credentials in .env — their discover calls the
    live APIs; without them, apply scripts/connectors-ddl/{hubspot,salesforce}.sql
    to seed their bronze, then run the dbt step
cd src/ingestion/scripts/bootstrap-db
set -a; source pins.env; source .env; set +a
./bootstrap-db.sh connectors-config.yaml   # fresh ClickHouse 25.7.5
./dump-ddl.sh                              # writes scripts/connectors-ddl/*.sql

Commit the resulting scripts/connectors-ddl/*.sql diff. If nothing
changed, no snapshot update is needed. (Regeneration is manual for now.)

@cyberantonz
cyberantonz enabled auto-merge (squash) July 28, 2026 04:14
@cyberantonz
cyberantonz merged commit 033c8fc into constructorfabric:main Jul 28, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants