Skip to content

chore(m365): bump connector to 2.0.0 to dispatch dbt full-refresh (#736) - #1879

Merged
mitasovr merged 3 commits into
constructorfabric:mainfrom
mitasovr:claude/m365-736-major-fullrefresh
Jul 27, 2026
Merged

chore(m365): bump connector to 2.0.0 to dispatch dbt full-refresh (#736)#1879
mitasovr merged 3 commits into
constructorfabric:mainfrom
mitasovr:claude/m365-736-major-fullrefresh

Conversation

@mitasovr

Copy link
Copy Markdown
Contributor

Step 2 of the #736 cleanup (step 1 = #1875, which moved the descriptor to 1.0.0).

Why

The #736 unlicensed-user filter only affects go-forward source selection. The M365 collab feeders are materialized='incremental', so rows materialized before the filter landed (unlicensed users with isLicensed=false/null, or explicitly-empty assignedProducts) are not retro-deleted and keep flowing into silver/gold.

Per ADR-0015, a MAJOR descriptor bump makes reconcile dispatch a one-shot dbt --full-refresh over the connector's dbt_select (tag:m365+). That re-materializes the m365 staging models + downstream silver class_collab_* from append-only bronze, applying the license filter to all history and purging the stale unlicensed rows.

- version: "1.0.0"
+ version: "2.0.0"

⚠️ Merge/deploy ordering (important)

The full-refresh only fires if the currently reconciled version is already semver (1.0.0). classify_bump compares the descriptor target against the Airbyte-side current:

  • if current = 1.0.0 (semver) → majorfull-refresh dispatched
  • if current = legacy 2026.05.04 (non-semver) → migrationno full-refresh

So this PR must be deployed only after #1875 (1.0.0) has reconciled to the live environment. If both land in the same reconcile with no intermediate tick, the current side is still 2026.05.04 and this degrades to a migration.

Scope / safety

  • No cross-connector cascade: tag:m365+ re-materializes only m365's downstream (incl. silver models that union m365; bronze is append-only so unrelated sources are read, not resynced) — per ADR-0015.
  • Descriptor-only change; no dbt/model edits.

Refs #736. Follows #1875.

🤖 Generated with Claude Code

Step 2 of the constructorfabric#736 cleanup. 1.0.0 (constructorfabric#1875) established the semver baseline as a
`migration` with no data action. This MAJOR bump makes reconcile dispatch a
one-shot `dbt --full-refresh` over `dbt_select` (tag:m365+) per ADR-0015, which
re-materializes the m365 staging + downstream silver from append-only bronze and
thereby purges the unlicensed collab rows that incremental models left behind
before the constructorfabric#736 filter landed.

PREREQUISITE: deploy only after the 1.0.0 release has reconciled to the live
environment. If the Airbyte-side current version is still the legacy non-semver
"2026.05.04", classify_bump treats this as `migration` and NO full-refresh is
dispatched.

Refs constructorfabric#736.

Signed-off-by: Roman Mitasov <Roman.Mitasov@constructor.tech>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mitasovr
mitasovr requested a review from a team as a code owner July 23, 2026 13:25
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mitasovr, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e824b859-e152-4a1c-81a7-157e4edc7c20

📥 Commits

Reviewing files that changed from the base of the PR and between 9ae00ab and 2be71bc.

📒 Files selected for processing (1)
  • src/ingestion/connectors/collaboration/m365/descriptor.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mitasovr
mitasovr marked this pull request as draft July 23, 2026 13:43
@mitasovr
mitasovr marked this pull request as ready for review July 27, 2026 03:41
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Regenerate the connectors-ddl snapshot

This PR changes src/ingestion/**. If your change affects any
bronze / silver / gold schema, regenerate the committed DDL snapshot
and include it in this PR:

cd src/ingestion/scripts/bootstrap-db
set -a; source pins.env; source .env; set +a
./bootstrap-db.sh connectors-config.yaml   # fresh ClickHouse 25.7.5
./dump-ddl.sh                              # writes scripts/connectors-ddl/*.sql

Commit the resulting scripts/connectors-ddl/*.sql diff. If nothing
changed, no snapshot update is needed. (Regeneration is manual for now.)

@mitasovr
mitasovr requested a review from ktursunov July 27, 2026 03:41
@mitasovr
mitasovr enabled auto-merge (squash) July 27, 2026 04:16
@mitasovr
mitasovr merged commit 87b3883 into constructorfabric:main Jul 27, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants