fix(ingestion): tag jira__task_field_metadata as staging so enrich builds it (#1743) - #1844
Merged
cyberantonz merged 2 commits intoJul 22, 2026
Conversation
…ilds it (constructorfabric#1743) The pipeline's staging phase selects `tag:staging,tag:jira` (an intersection). `jira__task_field_metadata` was tagged only `['jira', 'silver:...]`, so the intersection never built it — yet jira-enrich reads `staging.jira__task_field_metadata` (reader.rs), so the step aborted and `silver.class_task_*` stayed empty, blanking all Task Delivery + Code Quality KPIs despite a successful Jira sync. Add the `staging` tag (matching the sibling enrich inputs jira__changelog_items / jira__issue_field_snapshot) so it builds in the staging phase. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Anton Zelenov <antonz@constructor.tech>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Jira task field metadata dbt model now includes the ChangesJira staging selection
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ktursunov
approved these changes
Jul 22, 2026
…ror)
The explanatory comment was placed with `--` INSIDE the `{{ config(...) }}`
Jinja expression, which isn't valid Jinja — dbt parse failed with
"invalid syntax for function call expression" and every metrics e2e test
errored. Move it below the config block (SQL comment space). The `staging`
tag itself is unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Anton Zelenov <antonz@constructor.tech>
mitasovr
approved these changes
Jul 22, 2026
ktursunov
pushed a commit
to ktursunov/insight
that referenced
this pull request
Jul 23, 2026
…ilds it (constructorfabric#1743) (constructorfabric#1844) * fix(ingestion): tag jira__task_field_metadata as staging so enrich builds it (constructorfabric#1743) The pipeline's staging phase selects `tag:staging,tag:jira` (an intersection). `jira__task_field_metadata` was tagged only `['jira', 'silver:...]`, so the intersection never built it — yet jira-enrich reads `staging.jira__task_field_metadata` (reader.rs), so the step aborted and `silver.class_task_*` stayed empty, blanking all Task Delivery + Code Quality KPIs despite a successful Jira sync. Add the `staging` tag (matching the sibling enrich inputs jira__changelog_items / jira__issue_field_snapshot) so it builds in the staging phase. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Anton Zelenov <antonz@constructor.tech> * fix(ingestion): move note out of the {{ config }} block (dbt parse error) The explanatory comment was placed with `--` INSIDE the `{{ config(...) }}` Jinja expression, which isn't valid Jinja — dbt parse failed with "invalid syntax for function call expression" and every metrics e2e test errored. Move it below the config block (SQL comment space). The `staging` tag itself is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Anton Zelenov <antonz@constructor.tech> --------- Signed-off-by: Anton Zelenov <antonz@constructor.tech> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1743.
Problem
After a successful Jira sync, Task Delivery and Code Quality KPIs are all blank (
silver.class_task_*= 0) even thoughbronze_jira.jira_issueis populated.Root cause
The pipeline's staging phase runs
dbt_select_staging = "tag:staging,tag:jira"— a comma is an intersection.jira__task_field_metadatawas tagged only['jira', 'silver:class_task_field_metadata'](nostaging), so the intersection never built it. Butjira-enrichreads it first thing —FROM staging.jira__task_field_metadata(enrich/src/io/reader.rs:34) — so the enrich step aborts on the missing relation and the pipeline stops before silver, leavingclass_task_*empty.Its sibling enrich inputs
jira__changelog_itemsandjira__issue_field_snapshotare both tagged['staging', 'jira']and build fine —jira__task_field_metadatawas the lone outlier.Fix
Add the
stagingtag (one line) so it builds in the staging phase alongside the other enrich inputs:This matches the issue's suggested fix and the sibling models. Low-risk: adding a tag only makes the model eligible in one more selector; the
silver:union tag is unchanged.Verification
Traced statically: enrich's
fetch_field_metadatareadsstaging.jira__task_field_metadata; the model was the only enrich input missingstaging. The issue's confirmed workaround (dbt_select_staging = "tag:jira") builds it — this fix makes the default intersection build it too. (Full pipeline needs ClickHouse+Argo; not runnable locally.)🤖 Generated with Claude Code
Summary by CodeRabbit
stagingclassification for Jira task field metadata.