fix(gold): resolve task_status_intervals name collision - #1835
Conversation
Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe task lifecycle dbt model is renamed from ChangesTask status spans rename
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)src/ingestion/gold/schema.ymlTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The dbt gold model
task_status_intervals(materialized=table) and the refreshable materialized view of the same name from migrations 20260429/20260708 both targetinsight.task_status_intervals. The gold build runs after migrations in the deploy hook, so dbt replaces the MV with a MergeTree table; a later migration run then executesDROP VIEW IF EXISTS task_status_intervalsagainst a non-view and fails with code 80 (... is not a View), failing the post-upgrade hook.Rename the dbt model and its alias to
task_status_spans. The siblingtask_issue_statealready uses a name distinct from its MV counterparttask_issue_current_state; the intervals model missed the same treatment. Migrations are unchanged.Validated with
dbt parse(clean) anddbt ls:task_status_spans+resolvestask_metric_observations, andtask_status_intervalsno longer matches any node.🤖 Generated with Claude Code
Summary by CodeRabbit
task_status_spansname.