Skip to content

fix(ingestion): unblock deploy-time gold build - #1830

Merged
aleksdotbar merged 1 commit into
mainfrom
fix/clickhouse-migrate-gold-build
Jul 20, 2026
Merged

fix(ingestion): unblock deploy-time gold build#1830
aleksdotbar merged 1 commit into
mainfrom
fix/clickhouse-migrate-gold-build

Conversation

@aleksdotbar

@aleksdotbar aleksdotbar commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • render the vendored-path regex as Jinja output instead of literal concatenation syntax
  • only drop silver placeholders when their owning silver model is selected

Verification

  • ran the gold-tagged dbt models against ClickHouse with a materialized staging relation and placeholder present
  • all gold models built successfully and the placeholder remained available

Summary by CodeRabbit

  • Bug Fixes
    • Improved data processing so placeholder cleanup only applies to selected silver data models.
    • Corrected handling of configured vendored-file path patterns, ensuring non-empty patterns are properly applied.
    • Preserved the existing behavior for empty pattern configurations, which continue to match no files.

Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar>
@aleksdotbar
aleksdotbar requested a review from a team as a code owner July 20, 2026 11:59
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7e08bd48-f740-499d-b227-1b51cd47677b

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd666d and 0f5e79e.

📒 Files selected for processing (2)
  • src/ingestion/dbt/macros/drop_silver_placeholders_at_start.sql
  • src/ingestion/dbt/macros/git_file_category.sql

📝 Walkthrough

Walkthrough

Two dbt macros receive targeted fixes: silver placeholder detection is limited to selected resources, and non-empty vendored-path patterns are correctly emitted as a compiled regex string.

Changes

Silver placeholder selection

Layer / File(s) Summary
Filter silver placeholder evaluation
src/ingestion/dbt/macros/drop_silver_placeholders_at_start.sql
Silver placeholder detection now requires each node’s unique_id to be in selected_resources.

Vendored path regex output

Layer / File(s) Summary
Emit vendored path regex
src/ingestion/dbt/macros/git_file_category.sql
The non-empty pattern branch now outputs the constructed (?i)(...) regex string.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: ktursunov

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main goal of unblocking deploy-time gold builds through ingestion fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/clickhouse-migrate-gold-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aleksdotbar
aleksdotbar enabled auto-merge July 20, 2026 12:05
@aleksdotbar
aleksdotbar merged commit 8f41b4f into main Jul 20, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants