Skip to content

fix(ingestion): ms-entra descriptor version to strict semver (1.0 → 1.0.0) - #1747

Merged
ktursunov merged 2 commits into
mainfrom
fix/ms-entra-descriptor-semver
Jul 13, 2026
Merged

fix(ingestion): ms-entra descriptor version to strict semver (1.0 → 1.0.0)#1747
ktursunov merged 2 commits into
mainfrom
fix/ms-entra-descriptor-semver

Conversation

@ktursunov

@ktursunov ktursunov commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

ms-entra/descriptor.yaml pinned version: '1.0' — a two-part string. reconcile-connectors/python/classify_bump.py requires the target version to be strict semver MAJOR.MINOR.PATCH (ADR-0015) and exits 2 otherwise, so the reconcile connector definition step aborts and ms-entra is never published or synced.

Fix

Normalize version: '1.0' → '1.0.0'. All other nocode connectors already use 3-part versions (jira 2.3.0, confluence 1.2.0, chatgpt-team 2.0.0).

Evidence

On a fresh stand, reconcile-connectors/main.sh --connector ms-entra aborts with exit code 2 ("failed to reconcile connector definition"); after this change it reconciles cleanly (sync_catalog refreshed … 0 errors) and bronze_ms_entra populates.

Summary by CodeRabbit

  • Chores
    • Updated the Microsoft Entra connector descriptor version to 1.0.0.

@ktursunov
ktursunov requested a review from a team as a code owner July 13, 2026 11:49
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ktursunov, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 035cd3b1-e513-4733-a1f2-9f25b9ad878d

📥 Commits

Reviewing files that changed from the base of the PR and between 50318f3ddd63f9b1d9d6a83fa97a14590a23ae0c and e933d57.

📒 Files selected for processing (1)
  • src/ingestion/connectors/hr-directory/ms-entra/descriptor.yaml
📝 Walkthrough

Walkthrough

The Microsoft Entra connector descriptor version is updated from 1.0 to 1.0.0; no other configuration fields change.

Changes

Microsoft Entra connector

Layer / File(s) Summary
Descriptor version update
src/ingestion/connectors/hr-directory/ms-entra/descriptor.yaml
Changes the top-level version field from 1.0 to 1.0.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: normalizing the ms-entra descriptor version to strict semver.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ms-entra-descriptor-semver

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…1.0.0)

The ms-entra connector descriptor pinned version: '1.0', a two-part
string. reconcile-connectors' classify_bump.py requires the target
version to be strict semver MAJOR.MINOR.PATCH (ADR-0015) and exits 2
otherwise, so 'reconcile connector definition' aborts and the connector
is never published/synced. Normalize to '1.0.0' (all other nocode
connectors use 3-part versions, e.g. jira 2.3.0, confluence 1.2.0).

Signed-off-by: Konstantin Tursunov <Konstantin.Tursunov@constructor.tech>
@ktursunov
ktursunov force-pushed the fix/ms-entra-descriptor-semver branch from 50318f3 to 3dfc963 Compare July 13, 2026 11:54
@ktursunov
ktursunov enabled auto-merge July 13, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants