fix(ingestion): ms-entra descriptor version to strict semver (1.0 → 1.0.0) - #1747
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between 50318f3ddd63f9b1d9d6a83fa97a14590a23ae0c and e933d57. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Microsoft Entra connector descriptor version is updated from ChangesMicrosoft Entra connector
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…1.0.0) The ms-entra connector descriptor pinned version: '1.0', a two-part string. reconcile-connectors' classify_bump.py requires the target version to be strict semver MAJOR.MINOR.PATCH (ADR-0015) and exits 2 otherwise, so 'reconcile connector definition' aborts and the connector is never published/synced. Normalize to '1.0.0' (all other nocode connectors use 3-part versions, e.g. jira 2.3.0, confluence 1.2.0). Signed-off-by: Konstantin Tursunov <Konstantin.Tursunov@constructor.tech>
50318f3 to
3dfc963
Compare
Summary
ms-entra/descriptor.yamlpinnedversion: '1.0'— a two-part string.reconcile-connectors/python/classify_bump.pyrequires the target version to be strict semverMAJOR.MINOR.PATCH(ADR-0015) and exits 2 otherwise, so the reconcile connector definition step aborts and ms-entra is never published or synced.Fix
Normalize
version: '1.0' → '1.0.0'. All other nocode connectors already use 3-part versions (jira2.3.0, confluence1.2.0, chatgpt-team2.0.0).Evidence
On a fresh stand,
reconcile-connectors/main.sh --connector ms-entraaborts with exit code 2 ("failed to reconcile connector definition"); after this change it reconciles cleanly (sync_catalog refreshed … 0 errors) and bronze_ms_entra populates.Summary by CodeRabbit
1.0.0.