test(identity): wire coverlet.collector for .NET coverage - #1329
test(identity): wire coverlet.collector for .NET coverage#1329SharedQA wants to merge 2 commits into
Conversation
|
Warning Review limit reached
More reviews will be available in 57 minutes and 30 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds coverlet.collector to both identity test projects so 'dotnet test --collect:"XPlat Code Coverage"' emits cobertura — the .NET equivalent of the Rust llvm-cov / dbt gates. Identity was uninstrumented. Measured (SDK 9.0): UNIT line coverage 24.3% (Domain 61.8%, Infrastructure 24.8%, Api 8.2%); the Api/Infrastructure surface is exercised mainly by the 145 Testcontainers integration tests, so the combined unit+integration figure is materially higher. A merged unit+integration report (reportgenerator) + a ratchet is the follow-up to gate a single combined number. Signed-off-by: Kenan Salim <kenan.salim@rolos.com>
145cd5a to
c75f841
Compare
Review feedback on constructorfabric#1317 (cyberantonz): - "Why is coverage separate from unit tests?" — it wasn't justified: the suite ran twice (cargo test in `check`, then again instrumented in `coverage-unit`). Merge them: `check` now runs the suite ONCE under cargo-llvm-cov, which both runs the unit tests and measures line coverage + ratchets the floor. Deleted the duplicate `coverage-unit` job (nothing consumed its artifact separately). - "What about C# coverage?" — documented in place: .NET line coverage for identity is wired via the coverlet collector in constructorfabric#1329 (different tooling from Rust's cargo-llvm-cov, so it can't share the same command). - release-train: "What is infra/insight-gitops?" — it's the private GitOps deploy repo (documented in README). Reworded the release note to point at docs/components/deployment/gitops/README.md and dropped two unverified claims (an "allowlist gate" and approval on a `production` environment — no workflow uses a GitHub Environment). Signed-off-by: Kenan Salim <kenan.salim@rolos.com>
2 participants
Draft. Makes the .NET identity layer measurable — it was uninstrumented (no coverlet →
--collectproduced nothing).coverlet.collectortoInsight.Identity.Tests.Unitand.Integration.Follow-up (not in this PR): a merged unit+integration coverage report via
reportgeneratorto produce one combined % + a CI ratchet (mirrors the Rustcoverage.yml).