Skip to content

fix(silver): add zulip_proxy depends_on to shared identity_inputs - #1313

Merged
mitasovr merged 1 commit into
constructorfabric:mainfrom
mitasovr:fix/identity-inputs-zulip-depends-on
Jun 12, 2026
Merged

fix(silver): add zulip_proxy depends_on to shared identity_inputs#1313
mitasovr merged 1 commit into
constructorfabric:mainfrom
mitasovr:fix/identity-inputs-zulip-depends-on

Conversation

@mitasovr

@mitasovr mitasovr commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

The shared identity_inputs union (src/ingestion/silver/_shared/identity_inputs.sql) lists explicit -- depends_on: hints for every model tagged silver:identity_inputs (bamboohr, zoom, ms_entra, both seeds), but zulip_proxy__identity_inputs was missing.

Without the hint, dbt does not know about the dependency edge and may build the shared union before the zulip staging model on a first run — union_by_tag then silently skips the not-yet-materialised table, dropping zulip identities from the union.

Changes

  • Add -- depends_on: {{ ref('zulip_proxy__identity_inputs') }} to the header block of src/ingestion/silver/_shared/identity_inputs.sql.

Verification

  • Repo-wide grep confirms zulip_proxy__identity_inputs was the only silver:identity_inputs-tagged model missing from the header on this branch (outline__identity_inputs will need the same treatment once feat(ingestion): Outline wiki connector with Confluence-parity silver staging #1312 merges).
  • dbt parse passes with no errors.
  • dbt ls -s +identity_inputs now shows zulip_proxy__identity_inputs as an upstream of the shared union.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated data pipeline dependencies to ensure proper data lineage tracking and consistency across ingestion processes.

The shared identity_inputs union lists explicit depends_on hints for all
models tagged silver:identity_inputs, but zulip_proxy__identity_inputs
was missing. Without the hint, dbt may build the union before the zulip
staging model on a first run, and union_by_tag silently skips the
not-yet-materialised table.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Roman Mitasov <Roman.Mitasov@constructor.tech>
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2d769647-c56c-4eea-b907-9c4eeeb95283

📥 Commits

Reviewing files that changed from the base of the PR and between b20d2dd and d3ceead.

📒 Files selected for processing (1)
  • src/ingestion/silver/_shared/identity_inputs.sql

📝 Walkthrough

Walkthrough

This PR adds a dbt dependency directive to the identity_inputs.sql incremental model, explicitly declaring that it depends on zulip_proxy__identity_inputs. The change is a single-line addition to the model's metadata without modifications to the underlying query logic or behavior.

Changes

dbt Dependency Update

Layer / File(s) Summary
dbt dependency declaration
src/ingestion/silver/_shared/identity_inputs.sql
Added zulip_proxy__identity_inputs to the -- depends_on directive to establish explicit dependency tracking in the dbt model.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A dependency declared,
Clean metadata prepared,
One line of care,
Makes the DAG fair!
— Your friendly neighborhood Code Rabbit

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a missing dbt dependency (zulip_proxy__identity_inputs) to the shared identity_inputs model to fix a build order issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mitasovr
mitasovr merged commit a72ebd6 into constructorfabric:main Jun 12, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant