fix(silver): add zulip_proxy depends_on to shared identity_inputs - #1313
Conversation
The shared identity_inputs union lists explicit depends_on hints for all models tagged silver:identity_inputs, but zulip_proxy__identity_inputs was missing. Without the hint, dbt may build the union before the zulip staging model on a first run, and union_by_tag silently skips the not-yet-materialised table. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Roman Mitasov <Roman.Mitasov@constructor.tech>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a dbt dependency directive to the Changesdbt Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
The shared
identity_inputsunion (src/ingestion/silver/_shared/identity_inputs.sql) lists explicit-- depends_on:hints for every model taggedsilver:identity_inputs(bamboohr, zoom, ms_entra, both seeds), butzulip_proxy__identity_inputswas missing.Without the hint, dbt does not know about the dependency edge and may build the shared union before the zulip staging model on a first run —
union_by_tagthen silently skips the not-yet-materialised table, dropping zulip identities from the union.Changes
-- depends_on: {{ ref('zulip_proxy__identity_inputs') }}to the header block ofsrc/ingestion/silver/_shared/identity_inputs.sql.Verification
zulip_proxy__identity_inputswas the onlysilver:identity_inputs-tagged model missing from the header on this branch (outline__identity_inputswill need the same treatment once feat(ingestion): Outline wiki connector with Confluence-parity silver staging #1312 merges).dbt parsepasses with no errors.dbt ls -s +identity_inputsnow showszulip_proxy__identity_inputsas an upstream of the shared union.🤖 Generated with Claude Code
Summary by CodeRabbit