chore(connectors): bump jira/confluence descriptor versions to publish #1308 - #1310
Conversation
…constructorfabric#1308 Reconcile republishes a nocode declarative manifest only on descriptor version drift (descriptor version vs the version stored on the Airbyte definition; equal -> noop per ADR-0015). constructorfabric#1308 changed connector.yaml (default_concurrency 1 -> 4) without bumping descriptor versions, so reconcile on the deployed 0.1.59 correctly no-op'd and the deadlock fix never reached Airbyte: the active jira manifest (v3) and confluence manifest (v2) still carry default_concurrency: 1. (constructorfabric#1283 only got published because an unrelated image-ref bump had already moved jira's descriptor to 1.2.0.) - jira: 1.2.0 -> 1.2.1 - confluence: 1.1.0 -> 1.1.1 Also encode the lesson in the /connector skill (deploy prerequisites + validate descriptor checklist): bump descriptor.yaml version in the same PR as any connector.yaml change, or the manifest silently never ships. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR documents a descriptor version management policy and applies it to two connector descriptors. Deploy and validation workflows are updated to require version bumps in ChangesDescriptor Version Management Policy and Application
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Why
#1308 (jira/confluence
default_concurrency: 1 → 4, the CDK partition-deadlock fix) changedconnector.yamlwithout bumping the descriptor versions — and reconcile republishes a nocode declarative manifest only on descriptor-version drift (descriptorversionvs the version stored on the Airbyte definition; equal → noop per ADR-0015).Verified on virtuozzo after deploying umbrella 0.1.59 (toolbox
2a575de, contains #1308): reconcile ran clean but no-op'd both connectors — the active manifests in Airbyte (declarative_manifestv3 for jira, v2 for confluence) still carrydefault_concurrency: 1, so the deadlock fix never shipped. (#1283 only got through because an unrelated image-ref bump had already moved jira's descriptor to 1.2.0, creating accidental drift.)What
1.2.0 → 1.2.11.1.0 → 1.1.1Patch bump → reconcile classifies it as non-breaking: republish manifest + re-discover catalog, no full-refresh dispatch.
Also encodes the lesson into the
/connectorskill (deploy prerequisites + validate descriptor checklist): bumpdescriptor.yamlversionin the same PR as anyconnector.yamlchange — a manifest-only PR silently never reaches Airbyte (CI auto-bumps descriptors only for image-ref changes, not manifest edits).🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation