chore: scrub customer and personal references - #1302
Merged
Conversation
Deployment docs, dbt comments, migrations, identity docs, and test fixtures carried customer names, employee names/emails, and workstation paths. - replace customer env examples with acme/globex placeholders - replace real personas in identity walkthroughs and test fixtures with fictional ones (John/Jane Doe, example.com) - drop hardcoded customer email-domain filter from gold-views migration (view superseded; runner replays by filename, no checksums) - rename customer-named env template to .env.remote.example, neutralize contents - rewrite org-specific comment rationale as generic rules Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR generalizes environment/customer-specific examples across docs/scripts, replaces the identity-resolution walkthrough with a new Andrei Sokolov scenario, aligns identity migration/tests for case-insensitive value_id, and clarifies ingestion/dbt comments plus broadens a commits view filter. ChangesEnvironment and deployment configuration
Airbyte toolkit and connector docs
Identity resolution and persons schema
Data ingestion, dbt, and migration docs
Estimated code review effort: Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
docs/domain/identity-resolution/specs/DESIGN.md (1)
736-737:⚠️ Potential issue | 🟠 Major | ⚡ Quick winSchema contract is outdated for
persons.value_idcollation.This section documents
value_idasutf8mb4_binwith strict byte comparison, butMigrations/004_persons_relax_constraints.sqlchanges it toutf8mb4_unicode_ci. Please update this contract text to match runtime schema and avoid downstream implementation drift.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/domain/identity-resolution/specs/DESIGN.md` around lines 736 - 737, Update the DESIGN.md entry for the `persons.value_id` column to reflect the runtime collation used in the migrations: change the described collation from `utf8mb4_bin` to `utf8mb4_unicode_ci` and adjust the description to indicate case- and accent-insensitive comparison (matching `Migrations/004_persons_relax_constraints.sql`) while keeping the size justification (VARCHAR(320)) and the note about `value_type IN ('id','email','username')` and hot-path lookup behavior.src/ingestion/scripts/migrations/20260422000000_gold-views.sql (1)
140-155:⚠️ Potential issue | 🟡 MinorTenant-scoping replacement for
insight.commits_dailyis explicit in the superseding migration
20260427120000_views-from-silver.sqlreplacesinsight.commits_dailybyDROP VIEW IF EXISTS+CREATE VIEWand the new definition includesINNER JOIN insight.peoplewithWHERE p.status = 'Active'(so the intermediate, non-scoped definition should not persist past the second migration).Remaining check: ensure no queries depend on
insight.commits_dailyin the small window between the two migration files during a migration run/replay.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/ingestion/scripts/migrations/20260422000000_gold-views.sql` around lines 140 - 155, The current intermediate view insight.commits_daily can be visible during migration replay; to avoid a window without tenant-scoping, update the CREATE VIEW in 20260422000000_gold-views.sql so it matches the scoped definition used in the later migration: join bronze_bitbucket_cloud.commits to insight.people (use the same join key as the later migration, e.g., lower(author_email) = p.person_id or whatever the later migration uses), include the INNER JOIN insight.people AS p and add WHERE p.status = 'Active' so the initial view is tenant-scoped from the start and prevents any dependent queries from observing an unscoped view.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/components/deployment/gitops/README.md`:
- Line 304: In docs/components/deployment/gitops/README.md locate the sentence
in §3.3 that links to the broken fragment '`#34-engineer-pulls-and-deploys`' and
fix the cross-reference: open the document, find the actual heading for section
3.4 ("Engineer pulls and deploys"), then update the link target to the correct
slug for that heading (or add an explicit HTML anchor) so the reference from
§3.3 points to the real section 3.4 instead of '`#34-engineer-pulls-and-deploys`'.
In `@docs/domain/identity-resolution/specs/DESIGN.md`:
- Line 1337: Update the stale alias example in the DESIGN.md line that reads
"**After name alias enrichment** (`alexei` <-> `alexey`): BambooHR and YouTrack
get synthetic tokens for each other's name spelling." to use the current
walkthrough/seed aliases `andrei` <-> `andrey` so the example matches the Andrei
walkthrough and seed data; locate the "**After name alias enrichment**" sentence
and replace the backticked names `alexei` and `alexey` with `andrei` and
`andrey` respectively.
In `@inbox/IDENTITY_RESOLUTION.md`:
- Around line 188-195: The fenced code block containing the identity-resolution
example (lines like h2 ←— "sokol" —→ h3, h4 ←— "a.sokolov@gmail.com" —→ h5, h5
←— "andrey sokolov" —→ h1) is missing a language tag; add a language identifier
(for example ```text) to the opening backticks of that code fence so the block
is lint-compliant (e.g., change ``` to ```text).
---
Outside diff comments:
In `@docs/domain/identity-resolution/specs/DESIGN.md`:
- Around line 736-737: Update the DESIGN.md entry for the `persons.value_id`
column to reflect the runtime collation used in the migrations: change the
described collation from `utf8mb4_bin` to `utf8mb4_unicode_ci` and adjust the
description to indicate case- and accent-insensitive comparison (matching
`Migrations/004_persons_relax_constraints.sql`) while keeping the size
justification (VARCHAR(320)) and the note about `value_type IN
('id','email','username')` and hot-path lookup behavior.
In `@src/ingestion/scripts/migrations/20260422000000_gold-views.sql`:
- Around line 140-155: The current intermediate view insight.commits_daily can
be visible during migration replay; to avoid a window without tenant-scoping,
update the CREATE VIEW in 20260422000000_gold-views.sql so it matches the scoped
definition used in the later migration: join bronze_bitbucket_cloud.commits to
insight.people (use the same join key as the later migration, e.g.,
lower(author_email) = p.person_id or whatever the later migration uses), include
the INNER JOIN insight.people AS p and add WHERE p.status = 'Active' so the
initial view is tenant-scoped from the start and prevents any dependent queries
from observing an unscoped view.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1b87fa8d-9ab8-49da-9b03-539a190b7a18
📒 Files selected for processing (35)
.claude/skills/connector-status.md.env.remote.exampleDEVLOG.mddev-restart.shdev-up.shdocs/components/airbyte-toolkit/specs/ADR/0001-version-driven-reconcile.mddocs/components/airbyte-toolkit/specs/ADR/0002-adoption-of-existing-resources.mddocs/components/airbyte-toolkit/specs/ADR/0003-credential-rotation-no-env.mddocs/components/airbyte-toolkit/specs/ADR/0004-cluster-config-via-configmap.mddocs/components/airbyte-toolkit/specs/DESIGN.mddocs/components/connectors/collaboration/zulip-proxy/REPRODUCIBILITY-LOG.mddocs/components/connectors/collaboration/zulip-proxy/specs/FEATURE.mddocs/components/deployment/gitops/README.mddocs/components/deployment/specs/DESIGN.mddocs/components/deployment/specs/PRD.mddocs/components/deployment/specs/sop/connector-image-rebuild.mddocs/domain/identity-resolution/specs/DESIGN.mddocs/domain/ingestion-data-flow/specs/ADR/0001-rmt-with-version-and-unique-key.mddocs/domain/ingestion/specs/DESIGN.mdinbox/IDENTITY_RESOLUTION.mdinbox/architecture/CONNECTOR_AUTOMATION.mdinbox/architecture/IDENTITY_RESOLUTION_V2.mdinbox/architecture/PRODUCT_SPECIFICATION.mdinbox/architecture/STORAGE_TECHNOLOGY_EVALUATION.mdsrc/backend/services/identity/src/Insight.Identity.Infrastructure/Migrations/004_persons_relax_constraints.sqlsrc/backend/services/identity/tests/Insight.Identity.Tests.Integration/JwtCallerResolveTests.cssrc/backend/services/identity/tests/Insight.Identity.Tests.Integration/PersonsSchemaTests.cssrc/ingestion/connectors/ai/claude-admin/dbt/claude_admin__ai_dev_usage.sqlsrc/ingestion/connectors/ai/claude-admin/dbt/schema.ymlsrc/ingestion/connectors/collaboration/zoom/dbt/zoom__collab_meeting_activity.sqlsrc/ingestion/connectors/crm/hubspot/dbt/hubspot__crm_deals.sqlsrc/ingestion/dbt/audit_rmt_read_dedup.pysrc/ingestion/dbt/macros/union_by_tag.sqlsrc/ingestion/scripts/migrations/20260422000000_gold-views.sqlsrc/ingestion/scripts/migrations/20260427120000_views-from-silver.sql
💤 Files with no reviewable changes (1)
- src/ingestion/connectors/ai/claude-admin/dbt/schema.yml
mitasovr
approved these changes
Jun 11, 2026
- repoint broken cross-reference to actual deploy section - align alias example and value_id collation docs with current state - tenant-scope transient commits_daily via insight.people join Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Tenant-scoping join in gold-views and value_id collation doc update change behavior/spec beyond the reference scrub; deferred to follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment docs, dbt comments, migrations, identity docs, and test fixtures carried customer names, employee names/emails, and workstation paths.
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation
Chores